Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

roachtest: remove RequiresLicense test spec #137311

Merged
merged 1 commit into from
Dec 13, 2024

Conversation

DarrylWong
Copy link
Contributor

@DarrylWong DarrylWong commented Dec 11, 2024

As of #135326, roachprod will now generate an
enterprise license if one is not supplied, making
the test spec no longer need.

Release note: none
Epic: none
Fixes: none

@cockroach-teamcity
Copy link
Member

This change is Reviewable

@DarrylWong DarrylWong force-pushed the remove-require-license branch from d09fc22 to 25247c0 Compare December 13, 2024 17:19
@DarrylWong DarrylWong marked this pull request as ready for review December 13, 2024 17:26
@DarrylWong DarrylWong requested a review from a team as a code owner December 13, 2024 17:26
@DarrylWong DarrylWong requested review from sambhav-jain-16 and shailendra-patel and removed request for a team December 13, 2024 17:26
@srosenberg
Copy link
Member

As of #135326, roachprod will now generate an enterprise license if one is not supplied, making the test spec no longer need.

Good riddance! Should we also remove RequiresLicense from TestSpec?

@srosenberg srosenberg self-requested a review December 13, 2024 17:33
Copy link
Member

@srosenberg srosenberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

As of cockroachdb#135326, roachprod will now generate an
enterprise license if one is not supplied, making
the test spec no longer need.
@DarrylWong DarrylWong force-pushed the remove-require-license branch from 25247c0 to aefb582 Compare December 13, 2024 17:44
@DarrylWong
Copy link
Contributor Author

Good riddance! Should we also remove RequiresLicense from TestSpec?

🤦 Totally thought I did for some reason. Gone now though!

@DarrylWong
Copy link
Contributor Author

TFTR!

bors r=srosenberg

@craig craig bot merged commit 3878bf6 into cockroachdb:master Dec 13, 2024
22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants