roachtest: allow for overriding mvt planner params through env vars #137312
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change is |
DarrylWong
force-pushed
the
mvt-env-var-override
branch
4 times, most recently
from
7106ac3 to
0e22e10
Compare
|
I personally found this very useful when testing out I still think a dry run mode would be good, complimentary with this even, since I don't see an easy way to handcraft when certain steps are inserted through env vars. But from anecdotal experience, it seems like most mixed version bugs repro with just the version and deployment mode. |
DarrylWong
requested review from
sambhav-jain-16 and
shailendra-patel
and removed request for
a team
srosenberg
reviewed
Dec 19, 2024
srosenberg
reviewed
Dec 20, 2024
srosenberg
reviewed
Dec 20, 2024
| // LatestPatchRelease returns the latest patch release version for a given | ||
| // release series. | ||
| func LatestPatchRelease(series string) (*Version, error) { | ||
| seriesStr := strings.TrimPrefix(series, "v") |
There was a problem hiding this comment.
The ping-pong around the "v" prefix is amusing.
srosenberg
approved these changes
Dec 20, 2024
When debugging mixed version tests, one often wishes to generate a specific upgrade path or use a specific deployment mode. The latter is not possible without changing the source code while the former is not supported at all. This change exposes two env vars, MVT_UPGRADE_PATH and MVT_DEPLOYMENT_MODE to allow for overriding mixed version plan generation.
DarrylWong
force-pushed
the
mvt-env-var-override
branch
from
0e22e10 to
c34f407
Compare
|
TFTR! bors r=srosenberg |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When debugging mixed version tests, one often wishes to generate a specific
upgrade path or use a specific deployment mode. The latter is not possible
without changing the source code while the former is not supported at all.
This change exposes two env vars, MVT_UPGRADE_PATH and MVT_DEPLOYMENT_MODE
to allow for overriding mixed version plan generation.
Release note: none
Epic: none
Fixes: none