ccl/changefeedccl/cdcevent: Fix flake in TestEventColumnOrderingWithSchemaChanges #137334
Conversation
|
This change is |
There was a problem hiding this comment.
Thanks for the quick changes!
Reviewable status:
complete! 1 of 0 LGTMs obtained (waiting on @spilchen)
pkg/ccl/changefeedccl/cdcevent/event_test.go line 739 at r1 (raw file):
} { t.Run(tc.testName, func(t *testing.T) { log.Infof(ctx, "%s", tc.testName)
nit: this is be unnecessary. The test name will be logged by the test when it starts running (or when it's paused/resumed/succeeded/failed), like:
=== RUN TestEventColumnOrderingWithSchemaChanges/main/main_cols_no_rewrite
pkg/ccl/changefeedccl/cdcevent/event_test.go line 741 at r1 (raw file):
log.Infof(ctx, "%s", tc.testName) sqlDB.ExecMultiple(t, `DROP TABLE IF EXISTS foo`,
Nice, thanks!
…chemaChanges This commit addresses a test flake in TestEventColumnOrderingWithSchemaChanges. The test relies on the SCHEMA CHANGE GC job, which triggers the RangeFeedDeleteRange event. Since this job runs asynchronously, delays in its execution occasionally caused the test to fail. To mitigate this, the test has been updated to ensure the job starts more promptly. Additionally, debugging aids have been added to facilitate future investigations if the test fails again. Epic: None Closes cockroachdb#136371 Release note: None
spilchen
force-pushed
the
gh-136371/241212/0802/cdc-tc-fix
branch
from
b573786 to
cffa888
Compare
There was a problem hiding this comment.
Reviewable status:
pkg/ccl/changefeedccl/cdcevent/event_test.go line 739 at r1 (raw file):
Previously, rharding6373 (Rachael Harding) wrote…
nit: this is be unnecessary. The test name will be logged by the test when it starts running (or when it's paused/resumed/succeeded/failed), like:
=== RUN TestEventColumnOrderingWithSchemaChanges/main/main_cols_no_rewrite
Makes sense.
|
TFTR! bors r+ |
This commit addresses a test flake in TestEventColumnOrderingWithSchemaChanges. The test relies on the SCHEMA CHANGE GC job, which triggers the RangeFeedDeleteRange event. Since this job runs asynchronously, delays in its execution occasionally caused the test to fail.
To mitigate this, the test has been updated to ensure the job starts more promptly. Additionally, debugging aids have been added to facilitate future investigations if the test fails again.
Epic: None
Closes #136371
Release note: None