Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

release-24.3: backup: rewrite UDT oids in histograms when restoring table stats #137353

Merged
merged 1 commit into from
Dec 12, 2024

Conversation

michae2
Copy link
Collaborator

@michae2 michae2 commented Dec 12, 2024

Backport 1/1 commits from #137242.

/cc @cockroachdb/release


During restore we need to rewrite any saved references to descriptor IDs and OIDs when restoring table statistics. We were rewriting references to table IDs, but not references to type OIDs for user-defined types.

Fixes: #137106

Release note (bug fix): Fix a bug that caused queries against tables with user-defined types to sometimes fail with errors after restoring those tables.


Release justification: fix for customer-discovered bug.

During restore we need to rewrite any saved references to descriptor IDs
and OIDs when restoring table statistics. We were rewriting references
to table IDs, but not references to type OIDs for user-defined types.

Fixes: cockroachdb#137106

Release note (bug fix): Fix a bug that caused queries against tables
with user-defined types to sometimes fail with errors after restoring
those tables.
@michae2 michae2 requested review from mgartner, rytaft and a team December 12, 2024 20:20
@michae2 michae2 requested review from a team as code owners December 12, 2024 20:20
@michae2 michae2 requested review from kev-cao and removed request for a team December 12, 2024 20:20
Copy link

blathers-crl bot commented Dec 12, 2024

Thanks for opening a backport.

Please check the backport criteria before merging:

  • Backports should only be created for serious
    issues
    or test-only changes.
  • Backports should not break backwards-compatibility.
  • Backports should change as little code as possible.
  • Backports should not change on-disk formats or node communication protocols.
  • Backports should not add new functionality (except as defined
    here).
  • Backports must not add, edit, or otherwise modify cluster versions; or add version gates.
  • All backports must be reviewed by the owning areas TL. For more information as to how that review should be conducted, please consult the backport
    policy
    .
If your backport adds new functionality, please ensure that the following additional criteria are satisfied:
  • There is a high priority need for the functionality that cannot wait until the next release and is difficult to address in another way.
  • The new functionality is additive-only and only runs for clusters which have specifically “opted in” to it (e.g. by a cluster setting).
  • New code is protected by a conditional check that is trivial to verify and ensures that it only runs for opt-in clusters. State changes must be further protected such that nodes running old binaries will not be negatively impacted by the new state (with a mixed version test added).
  • The PM and TL on the team that owns the changed code have signed off that the change obeys the above rules.
  • Your backport must be accompanied by a post to the appropriate Slack
    channel (#db-backports-point-releases or #db-backports-XX-X-release) for awareness and discussion.

Also, please add a brief release justification to the body of your PR to justify this
backport.

@blathers-crl blathers-crl bot added the backport Label PR's that are backports to older release branches label Dec 12, 2024
@cockroach-teamcity
Copy link
Member

This change is Reviewable

@michae2 michae2 removed the request for review from kev-cao December 12, 2024 20:21
Copy link
Collaborator

@rytaft rytaft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 3 of 3 files at r1, all commit messages.
Reviewable status: :shipit: complete! 1 of 0 LGTMs obtained (waiting on @mgartner)

@michae2 michae2 merged commit 6385b00 into cockroachdb:release-24.3 Dec 12, 2024
20 of 21 checks passed
@michae2 michae2 deleted the backport24.3-137242 branch December 12, 2024 23:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport Label PR's that are backports to older release branches
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants