Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

changefeedccl/kvfeed: add log for table that encountered schema change #137359

Merged
merged 1 commit into from
Dec 13, 2024

Conversation

andyyang890
Copy link
Collaborator

This patch adds a log documenting the table(s) that encountered schema
changes and caused the kv feed to restart/exit, which will be useful
for debugging.

Fixes #136624
Closes #134963

Release note: None

@andyyang890 andyyang890 requested a review from a team December 12, 2024 20:53
@andyyang890 andyyang890 requested a review from a team as a code owner December 12, 2024 20:53
@andyyang890 andyyang890 requested review from rharding6373 and removed request for a team December 12, 2024 20:53
Copy link

blathers-crl bot commented Dec 12, 2024

It looks like your PR touches production code but doesn't add or edit any test code. Did you consider adding tests to your PR?

🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is dev-inf.

@cockroach-teamcity
Copy link
Member

This change is Reviewable

Copy link
Collaborator

@rharding6373 rharding6373 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm: Would be useful to backport this, too.

Reviewable status: :shipit: complete! 1 of 0 LGTMs obtained

@andyyang890 andyyang890 force-pushed the 20241212-kv-feed-table-logs branch from 8e588f6 to e9d461e Compare December 12, 2024 21:05
@andyyang890 andyyang890 added backport-23.2.x Flags PRs that need to be backported to 23.2. backport-24.1.x Flags PRs that need to be backported to 24.1. backport-24.2.x Flags PRs that need to be backported to 24.2 backport-24.3.x Flags PRs that need to be backported to 24.3 labels Dec 12, 2024
@andyyang890 andyyang890 force-pushed the 20241212-kv-feed-table-logs branch 2 times, most recently from 7a26c66 to a5783fe Compare December 12, 2024 23:10
This patch adds a log documenting the table(s) that encountered schema
changes and caused the kv feed to restart/exit, which will be useful
for debugging.

Release note: None
@andyyang890 andyyang890 force-pushed the 20241212-kv-feed-table-logs branch from a5783fe to ddbb08e Compare December 13, 2024 01:30
@andyyang890
Copy link
Collaborator Author

TFTR!

bors r=rharding6373

@craig craig bot merged commit 57a7b11 into cockroachdb:master Dec 13, 2024
22 checks passed
Copy link

blathers-crl bot commented Dec 13, 2024

Based on the specified backports for this PR, I applied new labels to the following linked issue(s). Please adjust the labels as needed to match the branches actually affected by the issue(s), including adding any known older branches.


Issue #136624: branch-release-23.2, branch-release-24.1, branch-release-24.2, branch-release-24.3.


Issue #134963: branch-release-23.2, branch-release-24.1, branch-release-24.2, branch-release-24.3.


🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is dev-inf.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-23.2.x Flags PRs that need to be backported to 23.2. backport-24.1.x Flags PRs that need to be backported to 24.1. backport-24.2.x Flags PRs that need to be backported to 24.2 backport-24.3.x Flags PRs that need to be backported to 24.3
Projects
None yet
3 participants