-
Notifications
You must be signed in to change notification settings - Fork 3.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
changefeedccl/kvfeed: add log for table that encountered schema change #137359
changefeedccl/kvfeed: add log for table that encountered schema change #137359
Conversation
It looks like your PR touches production code but doesn't add or edit any test code. Did you consider adding tests to your PR? 🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is dev-inf. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would be useful to backport this, too.
Reviewable status: complete! 1 of 0 LGTMs obtained
8e588f6
to
e9d461e
Compare
7a26c66
to
a5783fe
Compare
This patch adds a log documenting the table(s) that encountered schema changes and caused the kv feed to restart/exit, which will be useful for debugging. Release note: None
a5783fe
to
ddbb08e
Compare
TFTR! bors r=rharding6373 |
Based on the specified backports for this PR, I applied new labels to the following linked issue(s). Please adjust the labels as needed to match the branches actually affected by the issue(s), including adding any known older branches. Issue #136624: branch-release-23.2, branch-release-24.1, branch-release-24.2, branch-release-24.3. Issue #134963: branch-release-23.2, branch-release-24.1, branch-release-24.2, branch-release-24.3. 🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is dev-inf. |
This patch adds a log documenting the table(s) that encountered schema
changes and caused the kv feed to restart/exit, which will be useful
for debugging.
Fixes #136624
Closes #134963
Release note: None