Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

teamcity: add build configuration to wrap run-pgo-build #137365

Merged
merged 1 commit into from
Dec 18, 2024

Conversation

rickystewart
Copy link
Collaborator

@rickystewart rickystewart commented Dec 12, 2024

This build configuration wraps run-pgo-build to run a roachtest
with profiling enabled. The result profile is then uploaded to a GCS
bucket.

Part of: CRDB-44692
Epic: CRDB-41952
Release note: None

Copy link

blathers-crl bot commented Dec 12, 2024

It looks like your PR touches production code but doesn't add or edit any test code. Did you consider adding tests to your PR?

🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is dev-inf.

@cockroach-teamcity
Copy link
Member

This change is Reviewable

@rickystewart rickystewart force-pushed the generate-profile-build branch 2 times, most recently from 388e1d1 to 80e0363 Compare December 12, 2024 23:08
@rickystewart rickystewart changed the title teamcity: add script to run PGO build and collect profiles [WIP] teamcity: add build to run PGO script and upload profile Dec 12, 2024
@rickystewart rickystewart force-pushed the generate-profile-build branch 4 times, most recently from b4bea76 to b4d5aff Compare December 13, 2024 20:41
@rickystewart rickystewart changed the title [WIP] teamcity: add build to run PGO script and upload profile teamcity: add build configuration to wrap run-pgo-build Dec 13, 2024
@rickystewart
Copy link
Collaborator Author

First commit is from #137363 and can be ignored (currently being bors'ed)

@rickystewart rickystewart marked this pull request as ready for review December 13, 2024 20:42
@rickystewart rickystewart requested a review from a team as a code owner December 13, 2024 20:42
@rickystewart rickystewart requested a review from rail December 13, 2024 20:42
@rickystewart rickystewart force-pushed the generate-profile-build branch 2 times, most recently from db223f2 to 686e285 Compare December 13, 2024 20:50
This build configuration wraps `run-pgo-build` to run a roachtest
with profiling enabled. The result profile is then uploaded to a GCS
bucket.

Part of: CRDB-44692
Epic: CRDB-41952
Release note: None
@rickystewart rickystewart force-pushed the generate-profile-build branch from 686e285 to 9547d14 Compare December 18, 2024 16:09
@rickystewart
Copy link
Collaborator Author

bors r=rail

@craig craig bot merged commit 302f9bd into cockroachdb:master Dec 18, 2024
21 of 22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants