-
Notifications
You must be signed in to change notification settings - Fork 3.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
release-22.2: docgen: update BEGIN and SET TRANSACTION diagrams without iso level #137434
Conversation
Thanks for opening a backport. Please check the backport criteria before merging:
If your backport adds new functionality, please ensure that the following additional criteria are satisfied:
Also, please add a brief release justification to the body of your PR to justify this |
It looks like your PR touches production code but doesn't add or edit any test code. Did you consider adding tests to your PR? 🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is dev-inf. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, but I think we won't ever have another CRDB v22.2.x release, even for security fixes.
Reviewed 10 of 10 files at r1, all commit messages.
Reviewable status: complete! 0 of 0 LGTMs obtained (waiting on @taroface)
TFTR, see comment here: #137371 (comment) |
Closing since |
Backport 1/1 commits from #137368. (Same updates as #137371)
/cc @cockroachdb/release
Updated the
BEGIN
diagram for v23.1, which had been empty since this commit. (#137058 covers v23.2 and later.)Also updated the
SET TRANSACTION
diagram, which had not been displaying most of its syntax.Epic: none
Release note: none
Release justification: non-production code change