multitenant: add can_prepare_txns tenant capability #137457
Conversation
![blathers[crl]](https://avatars.githubusercontent.com/in/59700?s=40&u=373d9101a12edc3847d2fb6ae78e3adcfb4ca41e&v=4){kind=avatar}
|
Your pull request contains more than 1000 changes. It is strongly encouraged to split big PRs into smaller chunks. 🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is dev-inf. |
|
This change is |
nvanbenschoten
force-pushed
the
nvanbenschoten/2pcTenant
branch
from
0c05a52 to
f7f7e69
Compare
nvanbenschoten
force-pushed
the
nvanbenschoten/2pcTenant
branch
3 times, most recently
from
0f93871 to
d24646c
Compare
There was a problem hiding this comment.
Reviewed 14 of 14 files at r1, all commit messages.
Reviewable status:complete! 1 of 0 LGTMs obtained (waiting on @mw5h, @nvanbenschoten, and @rafiss)
pkg/ccl/multitenantccl/tenantcapabilitiesccl/testdata/can_prepare_txns line 48 at r1 (raw file):
---- ok
Do you think it's worth adding a test where we revoke the capability at this point (one the transaction has been prepared)? Just to make sure we're still able to finalize the prepared transaction by either committing it or rolling it back, and don't leave it hanging.
Informs cockroachdb#22329. This commit adds a new `can_prepare_txns` tenant capability, so that we don't allow secondary tenants to prepare transactions by default. Allowing an untrusted tenant to prepare transactions would allow it to block the progress of system-wide backups, so it is too dangerous to allow by default. Release note: None
nvanbenschoten
force-pushed
the
nvanbenschoten/2pcTenant
branch
from
d24646c to
7b23988
Compare
There was a problem hiding this comment.
TFTR!
bors r+
Reviewable status:
pkg/ccl/multitenantccl/tenantcapabilitiesccl/testdata/can_prepare_txns line 48 at r1 (raw file):
Previously, arulajmani (Arul Ajmani) wrote…
Do you think it's worth adding a test where we revoke the capability at this point (one the transaction has been prepared)? Just to make sure we're still able to finalize the prepared transaction by either committing it or rolling it back, and don't leave it hanging.
Good idea! Done.
Informs #22329.
This commit adds a new
can_prepare_txnstenant capability, so that we adon't allow secondary tenants to prepare transactions by default. Allowing aan untrusted tenant to prepare transactions would allow it to block the aprogress of system-wide backups, so it is too dangerous to allow by default.Release note: None