Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

release-24.1: changefeedccl: fix schema change boundary race condition #137704

Merged
merged 1 commit into from
Dec 19, 2024

Conversation

blathers-crl[bot]
Copy link

@blathers-crl blathers-crl bot commented Dec 18, 2024

Backport 1/1 commits from #137567 on behalf of @andyyang890.

/cc @cockroachdb/release


This patch fixes an issue where a schema change could incorrectly
cause a changefeed to fail with an assertion error like received boundary timestamp ... of type ... before reaching existing boundary of type ... due to a race condition between aggregators sending
resolved spans for multiple schema change descriptor updates to
the change frontier.

Fixes #136847

Release note (bug fix): An issue where a schema change could
incorrectly cause a changefeed to fail with an assertion error
like received boundary timestamp ... of type ... before reaching existing boundary of type ... has now been fixed.


Release justification: low-risk, high-value bug fix

@blathers-crl blathers-crl bot requested a review from a team as a code owner December 18, 2024 19:46
@blathers-crl blathers-crl bot requested review from rharding6373 and removed request for a team December 18, 2024 19:46
@blathers-crl blathers-crl bot added blathers-backport This is a backport that Blathers created automatically. O-robot Originated from a bot. labels Dec 18, 2024
Copy link
Author

blathers-crl bot commented Dec 18, 2024

Thanks for opening a backport.

Please check the backport criteria before merging:

  • Backports should only be created for serious
    issues
    or test-only changes.
  • Backports should not break backwards-compatibility.
  • Backports should change as little code as possible.
  • Backports should not change on-disk formats or node communication protocols.
  • Backports should not add new functionality (except as defined
    here).
  • Backports must not add, edit, or otherwise modify cluster versions; or add version gates.
  • All backports must be reviewed by the owning areas TL. For more information as to how that review should be conducted, please consult the backport
    policy
    .
If your backport adds new functionality, please ensure that the following additional criteria are satisfied:
  • There is a high priority need for the functionality that cannot wait until the next release and is difficult to address in another way.
  • The new functionality is additive-only and only runs for clusters which have specifically “opted in” to it (e.g. by a cluster setting).
  • New code is protected by a conditional check that is trivial to verify and ensures that it only runs for opt-in clusters. State changes must be further protected such that nodes running old binaries will not be negatively impacted by the new state (with a mixed version test added).
  • The PM and TL on the team that owns the changed code have signed off that the change obeys the above rules.
  • Your backport must be accompanied by a post to the appropriate Slack
    channel (#db-backports-point-releases or #db-backports-XX-X-release) for awareness and discussion.

Also, please add a brief release justification to the body of your PR to justify this
backport.

@blathers-crl blathers-crl bot added the backport Label PR's that are backports to older release branches label Dec 18, 2024
@cockroach-teamcity
Copy link
Member

This change is Reviewable

@andyyang890 andyyang890 removed their request for review December 18, 2024 20:08
This patch fixes an issue where a schema change could incorrectly
cause a changefeed to fail with an assertion error like `received
boundary timestamp ... of type ... before reaching existing boundary
of type ...` due to a race condition between aggregators sending
resolved spans for multiple schema change descriptor updates to
the change frontier.

Release note (bug fix): An issue where a schema change could
incorrectly cause a changefeed to fail with an assertion error
like `received boundary timestamp ... of type ... before reaching
existing boundary of type ...` has now been fixed.
@andyyang890 andyyang890 force-pushed the blathers/backport-release-24.1-137567 branch from 1a11a22 to 809f4ba Compare December 19, 2024 19:48
@andyyang890 andyyang890 merged commit 0a24c2c into release-24.1 Dec 19, 2024
19 of 20 checks passed
@andyyang890 andyyang890 deleted the blathers/backport-release-24.1-137567 branch December 19, 2024 23:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport Label PR's that are backports to older release branches blathers-backport This is a backport that Blathers created automatically. O-robot Originated from a bot.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants