upgrades: backfill new jobs cols/table #137728
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment was marked as off-topic.
This comment was marked as off-topic.
dt
force-pushed
the
jobs-backfill
branch
5 times, most recently
from
d5e20a7 to
c12dff0
Compare
msbutler
approved these changes
Dec 19, 2024
| jobutils.WaitForJobToSucceed(t, sqlDB, 1006) | ||
| jobutils.WaitForJobToFail(t, sqlDB, 1008) | ||
|
|
||
| // Let's look at the jobs table before the backfill. |
There was a problem hiding this comment.
Note to self: when you hook up SHOW JOBS, we should run historical queries at timestamps before/during the migrations.
There was a problem hiding this comment.
We can do that, but note that the type of gates we are using in all of these changes resolve to the version value as of the txn time, so if you run a historical your query to before V25_1_JobsBackfill was committed, SHOW won't use any of these tables.
There was a problem hiding this comment.
right, i think this would be a good test to have in your next pr since we were burned by this during the last jobs migration.
Release note: none. Epic: none.
msbutler
approved these changes
Dec 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Release note: none.
Epic: none.