Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

workload/schemachange: turn on exec logging for all statements #137774

Merged
merged 3 commits into from
Dec 20, 2024

Conversation

rafiss
Copy link
Collaborator

@rafiss rafiss commented Dec 19, 2024

workload: log full stack trace of error on failure

workload/schemachange: make ErrorState implement Cause()

This will make the error formatting work more conventionally.

workload/schemachange: turn on exec logging

This will help us see exactly which statements were executed by the
workload, including helper queries.

Epic: None
Release note: None

This will make the error formatting work more conventionally.

Release note: None
This will help us see exactly which statements were executed by the
workload, including helper queries.

Release note: None
@rafiss rafiss added backport-23.2.x Flags PRs that need to be backported to 23.2. backport-24.1.x Flags PRs that need to be backported to 24.1. backport-24.2.x Flags PRs that need to be backported to 24.2 backport-24.3.x Flags PRs that need to be backported to 24.3 labels Dec 19, 2024
@rafiss rafiss requested review from fqazi and a team December 19, 2024 15:26
@rafiss rafiss requested a review from a team as a code owner December 19, 2024 15:26
@rafiss rafiss requested review from shailendra-patel and csgourav and removed request for a team December 19, 2024 15:26
@cockroach-teamcity
Copy link
Member

This change is Reviewable

Copy link
Collaborator

@fqazi fqazi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 1 of 1 files at r1.
Reviewable status: :shipit: complete! 1 of 0 LGTMs obtained (waiting on @csgourav and @shailendra-patel)

@rafiss
Copy link
Collaborator Author

rafiss commented Dec 20, 2024

bors r+

Copy link

blathers-crl bot commented Dec 20, 2024

Encountered an error creating backports. Some common things that can go wrong:

  1. The backport branch might have already existed.
  2. There was a merge conflict.
  3. The backport branch contained merge commits.

You might need to create your backport manually using the backport tool.


error creating merge commit from 9a2e427 to blathers/backport-release-23.2-137774: POST https://api.github.com/repos/cockroachdb/cockroach/merges: 409 Merge conflict []

you may need to manually resolve merge conflicts with the backport tool.

Backport to branch 23.2.x failed. See errors above.


🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is dev-inf.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-23.2.x Flags PRs that need to be backported to 23.2. backport-24.1.x Flags PRs that need to be backported to 24.1. backport-24.2.x Flags PRs that need to be backported to 24.2 backport-24.3.x Flags PRs that need to be backported to 24.3
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants