Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

release-24.2: ttljob: fix frequency of logging progress #137778

Merged
merged 1 commit into from
Dec 19, 2024

Conversation

rafiss
Copy link
Collaborator

@rafiss rafiss commented Dec 19, 2024

The progress is supposed to be logged periodically, but the logic to check when the last log occurred was broken. This fixed it by resetting the count of spans processed since the last log.

informs #135170
Release justification: low risk logging fix
Release note: None

The progress is supposed to be logged periodically, but the logic to
check when the last log occurred was broken. This fixed it by resetting
the count of spans processed since the last log.

Release note: None
@rafiss rafiss added the backport-24.1.x Flags PRs that need to be backported to 24.1. label Dec 19, 2024
@rafiss rafiss requested a review from fqazi December 19, 2024 16:58
@rafiss rafiss requested a review from a team as a code owner December 19, 2024 16:58
Copy link

blathers-crl bot commented Dec 19, 2024

Thanks for opening a backport.

Please check the backport criteria before merging:

  • Backports should only be created for serious
    issues
    or test-only changes.
  • Backports should not break backwards-compatibility.
  • Backports should change as little code as possible.
  • Backports should not change on-disk formats or node communication protocols.
  • Backports should not add new functionality (except as defined
    here).
  • Backports must not add, edit, or otherwise modify cluster versions; or add version gates.
  • All backports must be reviewed by the owning areas TL. For more information as to how that review should be conducted, please consult the backport
    policy
    .
If your backport adds new functionality, please ensure that the following additional criteria are satisfied:
  • There is a high priority need for the functionality that cannot wait until the next release and is difficult to address in another way.
  • The new functionality is additive-only and only runs for clusters which have specifically “opted in” to it (e.g. by a cluster setting).
  • New code is protected by a conditional check that is trivial to verify and ensures that it only runs for opt-in clusters. State changes must be further protected such that nodes running old binaries will not be negatively impacted by the new state (with a mixed version test added).
  • The PM and TL on the team that owns the changed code have signed off that the change obeys the above rules.
  • Your backport must be accompanied by a post to the appropriate Slack
    channel (#db-backports-point-releases or #db-backports-XX-X-release) for awareness and discussion.

Also, please add a brief release justification to the body of your PR to justify this
backport.

@blathers-crl blathers-crl bot added the backport Label PR's that are backports to older release branches label Dec 19, 2024
Copy link

blathers-crl bot commented Dec 19, 2024

It looks like your PR touches production code but doesn't add or edit any test code. Did you consider adding tests to your PR?

🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is dev-inf.

@cockroach-teamcity
Copy link
Member

This change is Reviewable

@rafiss rafiss changed the title release-24.1: ttljob: fix frequency of logging progress release-24.2: ttljob: fix frequency of logging progress Dec 19, 2024
Copy link
Collaborator

@fqazi fqazi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status: :shipit: complete! 1 of 0 LGTMs obtained (waiting on @rafiss)

@rafiss rafiss merged commit ec35b23 into cockroachdb:release-24.2 Dec 19, 2024
19 of 20 checks passed
@rafiss rafiss deleted the ttl-fix-logs branch December 19, 2024 17:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport Label PR's that are backports to older release branches backport-24.1.x Flags PRs that need to be backported to 24.1.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants