Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

release-24.2: sql: allow CLOSE CURSOR in read-only txns #137791

Merged
merged 1 commit into from
Dec 24, 2024

Conversation

blathers-crl[bot]
Copy link

@blathers-crl blathers-crl bot commented Dec 19, 2024

Backport 1/1 commits from #137744 on behalf of @yuzefovich.

/cc @cockroachdb/release


This is allowed in PG, so we now will allow this too. The fix is similar to what we did for DECLARE and FETCH in 50a7999.

Fixes: #137606.

Release note (bug fix): CLOSE CURSOR statements are now allowed in read-only transactions, similat to Postgres. The bug has been present since at least 23.1 version.


Release justification: bug fix.

@blathers-crl blathers-crl bot requested a review from a team as a code owner December 19, 2024 19:36
@blathers-crl blathers-crl bot force-pushed the blathers/backport-release-24.2-137744 branch from 4e51b78 to 58f70e6 Compare December 19, 2024 19:36
@blathers-crl blathers-crl bot added blathers-backport This is a backport that Blathers created automatically. O-robot Originated from a bot. labels Dec 19, 2024
Copy link
Author

blathers-crl bot commented Dec 19, 2024

Thanks for opening a backport.

Please check the backport criteria before merging:

  • Backports should only be created for serious
    issues
    or test-only changes.
  • Backports should not break backwards-compatibility.
  • Backports should change as little code as possible.
  • Backports should not change on-disk formats or node communication protocols.
  • Backports should not add new functionality (except as defined
    here).
  • Backports must not add, edit, or otherwise modify cluster versions; or add version gates.
  • All backports must be reviewed by the owning areas TL. For more information as to how that review should be conducted, please consult the backport
    policy
    .
If your backport adds new functionality, please ensure that the following additional criteria are satisfied:
  • There is a high priority need for the functionality that cannot wait until the next release and is difficult to address in another way.
  • The new functionality is additive-only and only runs for clusters which have specifically “opted in” to it (e.g. by a cluster setting).
  • New code is protected by a conditional check that is trivial to verify and ensures that it only runs for opt-in clusters. State changes must be further protected such that nodes running old binaries will not be negatively impacted by the new state (with a mixed version test added).
  • The PM and TL on the team that owns the changed code have signed off that the change obeys the above rules.
  • Your backport must be accompanied by a post to the appropriate Slack
    channel (#db-backports-point-releases or #db-backports-XX-X-release) for awareness and discussion.

Also, please add a brief release justification to the body of your PR to justify this
backport.

@blathers-crl blathers-crl bot requested a review from rafiss December 19, 2024 19:36
@blathers-crl blathers-crl bot added the backport Label PR's that are backports to older release branches label Dec 19, 2024
@cockroach-teamcity
Copy link
Member

This change is Reviewable

This is allowed in PG, so we now will allow this too. The fix is similar
to what we did for DECLARE and FETCH in 50a7999.

Release note (bug fix): CLOSE CURSOR statements are now allowed in
read-only transactions, similat to Postgres. The bug has been present
since at least 23.1 version.
@yuzefovich yuzefovich force-pushed the blathers/backport-release-24.2-137744 branch from 58f70e6 to 05321e6 Compare December 23, 2024 21:32
@yuzefovich yuzefovich merged commit 4aec7dd into release-24.2 Dec 24, 2024
19 of 20 checks passed
@yuzefovich yuzefovich deleted the blathers/backport-release-24.2-137744 branch December 24, 2024 01:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport Label PR's that are backports to older release branches blathers-backport This is a backport that Blathers created automatically. O-robot Originated from a bot.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants