batcheval: refactor delete range #137803
Open
batcheval: refactor delete range #137803
+141
−109
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This refactors delete range to make it clear the implementation has three mutually exclusive implementations. The idempotent implementation is used by components like schema changer to delete whole table spans. The `predicates` implementation is used by import rollback. The transactional implementation has many users including sql and the time series db. Release Note: none Informs: cockroachdb#131844
![blathers[crl]](https://avatars.githubusercontent.com/in/59700?s=40&u=373d9101a12edc3847d2fb6ae78e3adcfb4ca41e&v=4){kind=avatar}
|
It looks like your PR touches production code but doesn't add or edit any test code. Did you consider adding tests to your PR? 🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is dev-inf. |
|
This change is |
stevendanna
approved these changes
Dec 20, 2024
| } | ||
| } | ||
|
|
||
| func deleteRangeIdempotent( |
There was a problem hiding this comment.
I'm not sure on the name of this one. Seems to me from the logic that we'll come here even if IdempotentTombstone is false? I'm not sure if I have a better name. Perhaps deleteRangeUsingTombostone to line up to the underlying storage call. That too is a bit of a misnomer since deleteRangeWithPredicate also uses tombstones.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This refactors delete range to make it clear the implementation has three mutually exclusive implementations. The idempotent implementation is used by components like schema changer to delete whole table spans. The
predicatesimplementation is used by import rollback. The transactional implementation has many users including sql and the time series db.Release Note: none
Informs: #131844