Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

release-24.3: dev: remove --strip=never configuration from .bazelrc.user #137833

Merged
merged 1 commit into from
Dec 20, 2024

Conversation

blathers-crl[bot]
Copy link

@blathers-crl blathers-crl bot commented Dec 20, 2024

Backport 1/1 commits from #137804 on behalf of @rickystewart.

/cc @cockroachdb/release


Previously we unconditionally disabled stripping; however, this has a negative impact on performance (linking gets much more expensive when you do not strip). This is a cost we paid both locally in the development cycle as well as in CI.

Removing this line from .bazelrc restores the default behavior of stripping iff the compilation_mode is fastbuild (which is the default). This will give developers the desired quick iteration behavior. You now have to opt into disabling stripping.

Going forward we may evaluate if it is worth it to disable stripping for unit tests in CI to enable the use of side-eye (#136839). Until that point, there is no reason to disable stripping in this context.

Stripping can be enabled with --strip=always or by passing -c dbg or -c opt. Notably, dev build --cross, the release process, and the roachtest nightlies all currently use -c opt when building, so there is nothing else to be done in these cases: they are all correctly not stripping.

Epic: CRDB-17171
Release note: None


Release justification: Non-production code changes

Previously we unconditionally disabled stripping; however, this has a
negative impact on performance (linking gets much more expensive when
you do not strip). This is a cost we paid both locally in the
development cycle as well as in CI.

Removing this line from `.bazelrc` restores the default behavior of
stripping iff the `compilation_mode` is `fastbuild` (which is the
default). This will give developers the desired quick iteration
behavior. You now have to opt into disabling stripping.

Going forward we may evaluate if it is worth it to disable stripping
for unit tests in CI to enable the use of `side-eye` (#136839). Until
that point, there is no reason to disable stripping in this context.

Stripping can be enabled with `--strip=always` or by passing `-c dbg` or
`-c opt`. Notably, `dev build --cross`, the release process, and the
`roachtest` nightlies all currently use `-c opt` when building, so there
is nothing else to be done in these cases: they are all correctly not
stripping.

Epic: CRDB-17171
Release note: None
@blathers-crl blathers-crl bot force-pushed the blathers/backport-release-24.3-137804 branch from 4df1004 to b71da16 Compare December 20, 2024 15:13
@blathers-crl blathers-crl bot added blathers-backport This is a backport that Blathers created automatically. O-robot Originated from a bot. labels Dec 20, 2024
Copy link
Author

blathers-crl bot commented Dec 20, 2024

Thanks for opening a backport.

Please check the backport criteria before merging:

  • Backports should only be created for serious
    issues
    or test-only changes.
  • Backports should not break backwards-compatibility.
  • Backports should change as little code as possible.
  • Backports should not change on-disk formats or node communication protocols.
  • Backports should not add new functionality (except as defined
    here).
  • Backports must not add, edit, or otherwise modify cluster versions; or add version gates.
  • All backports must be reviewed by the owning areas TL. For more information as to how that review should be conducted, please consult the backport
    policy
    .
If your backport adds new functionality, please ensure that the following additional criteria are satisfied:
  • There is a high priority need for the functionality that cannot wait until the next release and is difficult to address in another way.
  • The new functionality is additive-only and only runs for clusters which have specifically “opted in” to it (e.g. by a cluster setting).
  • New code is protected by a conditional check that is trivial to verify and ensures that it only runs for opt-in clusters. State changes must be further protected such that nodes running old binaries will not be negatively impacted by the new state (with a mixed version test added).
  • The PM and TL on the team that owns the changed code have signed off that the change obeys the above rules.
  • Your backport must be accompanied by a post to the appropriate Slack
    channel (#db-backports-point-releases or #db-backports-XX-X-release) for awareness and discussion.

Also, please add a brief release justification to the body of your PR to justify this
backport.

@blathers-crl blathers-crl bot added the backport Label PR's that are backports to older release branches label Dec 20, 2024
@cockroach-teamcity
Copy link
Member

This change is Reviewable

@rickystewart rickystewart merged commit 4b762dd into release-24.3 Dec 20, 2024
20 of 21 checks passed
@rickystewart rickystewart deleted the blathers/backport-release-24.3-137804 branch December 20, 2024 16:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport Label PR's that are backports to older release branches blathers-backport This is a backport that Blathers created automatically. O-robot Originated from a bot.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants