Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Debezium migration #17945

Merged
merged 7 commits into from
Oct 10, 2023
Merged

Debezium migration #17945

merged 7 commits into from
Oct 10, 2023

Conversation

gemma-shay
Copy link
Contributor

https://cockroachlabs.atlassian.net/browse/DOC-8307
New docs for using Debezium as a migration tool

@github-actions
Copy link

github-actions bot commented Sep 29, 2023 •
edited
Loading

Files changed:

@netlify
Copy link

netlify bot commented Sep 29, 2023 •
edited
Loading

✅ Deploy Preview for cockroachdb-interactivetutorials-docs canceled.

Name Link
🔨 Latest commit 5a01256
🔍 Latest deploy log https://app.netlify.com/sites/cockroachdb-interactivetutorials-docs/deploys/65259ba718c7330008ab2392

@netlify
Copy link

netlify bot commented Sep 29, 2023 •
edited
Loading

✅ Deploy Preview for cockroachdb-api-docs canceled.

Name Link
🔨 Latest commit 5a01256
🔍 Latest deploy log https://app.netlify.com/sites/cockroachdb-api-docs/deploys/65259ba70a7cd5000823519a

@netlify
Copy link

netlify bot commented Sep 29, 2023 •
edited
Loading

✅ Netlify Preview

Name Link
🔨 Latest commit 5a01256
🔍 Latest deploy log https://app.netlify.com/sites/cockroachdb-docs/deploys/65259ba789d2e40008173a0a
😎 Deploy Preview https://deploy-preview-17945--cockroachdb-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

cotedm
cotedm approved these changes Oct 5, 2023
View reviewed changes
Copy link
Contributor

@cotedm cotedm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM from content perspective

@gemma-shay gemma-shay requested a review from mdlinville October 5, 2023 19:46
@mdlinville
Copy link
Contributor

I believe you'll get past the build error if you rebase this PR.

mdlinville
mdlinville reviewed Oct 6, 2023
View reviewed changes
src/current/v23.1/debezium.md Outdated Show resolved Hide resolved
src/current/v23.1/debezium.md Outdated Show resolved Hide resolved
src/current/v23.1/debezium.md Outdated Show resolved Hide resolved
src/current/v23.1/debezium.md Outdated Show resolved Hide resolved
src/current/v23.1/debezium.md Outdated Show resolved Hide resolved
src/current/v23.1/debezium.md Show resolved Hide resolved
src/current/v23.1/debezium.md Outdated Show resolved Hide resolved
src/current/v23.1/debezium.md Show resolved Hide resolved
src/current/v23.2/debezium.md Outdated Show resolved Hide resolved
@mdlinville
Copy link
Contributor

Rebased for you to see if that fixes the build error.

mdlinville
mdlinville approved these changes Oct 10, 2023
View reviewed changes
Copy link
Contributor

@mdlinville mdlinville left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, would be nice to add the extra step to create the connection to Kafka.

@gemma-shay
Copy link
Contributor Author

@mdlinville Added the kafka connect API step that Dustin suggested. Also just realized I missed the comment about the JDBC link, added that as well.

@gemma-shay gemma-shay merged commit 8fc4b42 into main Oct 10, 2023
3 checks passed
@gemma-shay gemma-shay deleted the debezium branch October 10, 2023 19:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cotedm cotedm cotedm approved these changes

@mdlinville mdlinville mdlinville approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@gemma-shay @mdlinville @cotedm