DOC-8738: Warn users that generating the debug zip can degrade the cluster #17952
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for cockroachdb-interactivetutorials-docs canceled.
|
✅ Deploy Preview for cockroachdb-api-docs canceled.
|
✅ Netlify Preview
To edit notification comments on pull requests, go to your Netlify site configuration. |
gemma-shay
approved these changes
Oct 5, 2023
kevin-v-ngo
reviewed
Oct 6, 2023
There was a problem hiding this comment.
Hi @florence-crl, do you think we can include guidance and document this new flag? We have a few threads and issues related to the range info filter.
Doc issue: #16919
PR: cockroachdb/cockroach#102289
|
Before I can document #16919, I need to clarify what is the default value. For context, see this slack thread. |
|
Clarification: cockroachdb/cockroach#104133 changed the default to |
florence-crl
force-pushed
the
DOC-8738
branch
2 times, most recently
from
ac25b0f to
65d9c75
Compare
|
@dt, PTAL, I included your recommendation under the |
dt
reviewed
Oct 9, 2023
florence-crl
force-pushed
the
DOC-8738
branch
from
65d9c75 to
187817b
Compare
dt
approved these changes
Oct 10, 2023
kevin-v-ngo
approved these changes
Oct 23, 2023
…ommendation to filter by time range, and --include-range-info flag.
florence-crl
force-pushed
the
DOC-8738
branch
from
187817b to
da9fa8f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses DOC-8738
(1) Updated cockroach debug zip page with cluster impact warning and recommendation to filter by time range.