Fix macOS ARM download label on 23.2.0-alpha.2 and 23.2.0-alpha.3 #17987
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Files changed:
|
✅ Deploy Preview for cockroachdb-interactivetutorials-docs canceled.
|
✅ Deploy Preview for cockroachdb-api-docs canceled.
|
mdlinville
force-pushed
the
fix_macos_arm_download
branch
from
02791ea to
ef3c176
Compare
mdlinville
changed the title
✅ Netlify Preview
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Netlify Preview
To edit notification comments on pull requests, go to your Netlify site configuration. |
mdlinville
requested review from
ianjevans
and removed request for
rmloveland
ianjevans
approved these changes
Oct 10, 2023
mdlinville
force-pushed
the
fix_macos_arm_download
branch
from
ef3c176 to
50e5277
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
macOS ARM download links should still be experimental rather than limited access. In Prod, they are currently marked as both. It's intended that both should be a possibility, but it's not correct here.
Relates to https://github.com/cockroachdb/ed-tools/pull/50
(which fixes the logic bug, hopefully)