Add missing IntelliJ images (and links) to v24.3 #19231
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Touches a small part of DOC-113 Summary of changes: - Copy the IntelliJ SQL IDE screenshots to the v24.3 images directory - Fix the links on the page to point to reference the newly copied images
✅ Deploy Preview for cockroachdb-api-docs canceled.
|
✅ Deploy Preview for cockroachdb-interactivetutorials-docs canceled.
|
|
@taroface for context i'm doing this b/c i have some scripts that generate an even simpler HTML version of a subset of our docs (including, if needed, as one giant HTML page) which have a test that depends on these images The output of the script could be a stepping stone to us doing PDF or EPUB builds which is why i tagged DOC-113 although it's tangential |
✅ Netlify Preview
To edit notification comments on pull requests, go to your Netlify site configuration. |
taroface
approved these changes
Dec 17, 2024
rmloveland
deleted the
20241213-DOC-113-add-missing-images-for-offline-build
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Touches a small part of DOC-113
Summary of changes:
Copy the IntelliJ SQL IDE screenshots to the v24.3 images directory
Fix the links on the page to point to reference the newly copied images