-
Notifications
You must be signed in to change notification settings - Fork 468
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add release notes for v25.1.0-alpha.3 #19301
Conversation
Files changed:
|
✅ Deploy Preview for cockroachdb-interactivetutorials-docs canceled.
|
✅ Deploy Preview for cockroachdb-api-docs canceled.
|
✅ Netlify Preview
To edit notification comments on pull requests, go to your Netlify site configuration. |
0a93423
to
6ba1c08
Compare
d3de098
to
499a20a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Blocking primarily for the versions.csv
change - let me know if you need more context on this.
src/current/_data/versions.csv
Outdated
@@ -16,4 +16,4 @@ v23.2,2024-02-05,2025-02-05,2025-08-05,23.2.6,23.2.7,2024-07-08,2025-07-08,2026- | |||
v24.1,2024-05-20,2025-05-20,2025-11-20,24.1.5,24.1.6,2024-10-21,2025-10-21,2026-10-21,v23.2,release-24.1 | |||
v24.2,2024-08-12,2025-02-12,N/A,N/A,N/A,N/A,N/A,N/A,v24.1,release-24.2 | |||
v24.3,2024-11-18,2025-11-18,2026-05-18,N/A,N/A,N/A,N/A,N/A,v24.2,release-24.3 | |||
v25.1,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,v24.2,release-24.3 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this change should be reverted until generated-diagrams
gets release-25.1
branch, which it still doesn't have -- see https://cockroachlabs.slack.com/archives/C0306LF0W69/p1736285588302159 for context
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
DMed you about this
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ok bringing convo back here:
looked at https://github.com/cockroachdb/docs/blob/main/src/current/_data/versions.csv
and in latest commit updated versions.csv in this PR to match that
PTAL
Co-authored-by: Ryan Kuo <[email protected]>
Co-authored-by: Ryan Kuo <[email protected]>
Co-authored-by: Ryan Kuo <[email protected]>
Co-authored-by: Ryan Kuo <[email protected]>
Co-authored-by: Ryan Kuo <[email protected]>
Co-authored-by: Ryan Kuo <[email protected]>
Co-authored-by: Ryan Kuo <[email protected]>
Co-authored-by: Ryan Kuo <[email protected]>
Co-authored-by: Ryan Kuo <[email protected]>
…b/docs into release-notes-v25.1.0-alpha.3
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, just 2 small follow-up items!
Co-authored-by: Ryan Kuo <[email protected]>
Co-authored-by: Ryan Kuo <[email protected]>
Fixes REL-1718