Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add release notes for v25.1.0-alpha.3 #19301

Merged
merged 16 commits into from
Jan 15, 2025
Merged

Conversation

rmloveland
Copy link
Contributor

Fixes REL-1718

Copy link

github-actions bot commented Jan 13, 2025

Files changed:

  • src/current/_data/releases.yml
  • src/current/_includes/releases/v25.1/v25.1.0-alpha.3.md:

Copy link

netlify bot commented Jan 13, 2025

Deploy Preview for cockroachdb-interactivetutorials-docs canceled.

Name Link
🔨 Latest commit 81b73fe
🔍 Latest deploy log https://app.netlify.com/sites/cockroachdb-interactivetutorials-docs/deploys/67881442a913780008ae055e

Copy link

netlify bot commented Jan 13, 2025

Deploy Preview for cockroachdb-api-docs canceled.

Name Link
🔨 Latest commit 81b73fe
🔍 Latest deploy log https://app.netlify.com/sites/cockroachdb-api-docs/deploys/67881442aa54290008f803d2

Copy link

netlify bot commented Jan 13, 2025

Netlify Preview

Name Link
🔨 Latest commit 81b73fe
🔍 Latest deploy log https://app.netlify.com/sites/cockroachdb-docs/deploys/67881442b8ef96000878b7a0
😎 Deploy Preview https://deploy-preview-19301--cockroachdb-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@rmloveland rmloveland force-pushed the release-notes-v25.1.0-alpha.3 branch from 0a93423 to 6ba1c08 Compare January 14, 2025 16:30
@rmloveland rmloveland force-pushed the release-notes-v25.1.0-alpha.3 branch from d3de098 to 499a20a Compare January 14, 2025 19:07
@rmloveland rmloveland requested a review from taroface January 14, 2025 19:07
Copy link
Contributor

@taroface taroface left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Blocking primarily for the versions.csv change - let me know if you need more context on this.

@@ -16,4 +16,4 @@ v23.2,2024-02-05,2025-02-05,2025-08-05,23.2.6,23.2.7,2024-07-08,2025-07-08,2026-
v24.1,2024-05-20,2025-05-20,2025-11-20,24.1.5,24.1.6,2024-10-21,2025-10-21,2026-10-21,v23.2,release-24.1
v24.2,2024-08-12,2025-02-12,N/A,N/A,N/A,N/A,N/A,N/A,v24.1,release-24.2
v24.3,2024-11-18,2025-11-18,2026-05-18,N/A,N/A,N/A,N/A,N/A,v24.2,release-24.3
v25.1,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,v24.2,release-24.3
Copy link
Contributor

@taroface taroface Jan 14, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this change should be reverted until generated-diagrams gets release-25.1 branch, which it still doesn't have -- see https://cockroachlabs.slack.com/archives/C0306LF0W69/p1736285588302159 for context

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

DMed you about this

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok bringing convo back here:

looked at https://github.com/cockroachdb/docs/blob/main/src/current/_data/versions.csv

and in latest commit updated versions.csv in this PR to match that

PTAL

src/current/_includes/releases/v25.1/v25.1.0-alpha.3.md Outdated Show resolved Hide resolved
src/current/_includes/releases/v25.1/v25.1.0-alpha.3.md Outdated Show resolved Hide resolved
src/current/_includes/releases/v25.1/v25.1.0-alpha.3.md Outdated Show resolved Hide resolved
src/current/_includes/releases/v25.1/v25.1.0-alpha.3.md Outdated Show resolved Hide resolved
src/current/_includes/releases/v25.1/v25.1.0-alpha.3.md Outdated Show resolved Hide resolved
src/current/_includes/releases/v25.1/v25.1.0-alpha.3.md Outdated Show resolved Hide resolved
src/current/_includes/releases/v25.1/v25.1.0-alpha.3.md Outdated Show resolved Hide resolved
src/current/_includes/releases/v25.1/v25.1.0-alpha.3.md Outdated Show resolved Hide resolved
src/current/_includes/releases/v25.1/v25.1.0-alpha.3.md Outdated Show resolved Hide resolved
Copy link
Contributor

@taroface taroface left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just 2 small follow-up items!

src/current/_includes/releases/v25.1/v25.1.0-alpha.3.md Outdated Show resolved Hide resolved
src/current/_includes/releases/v25.1/v25.1.0-alpha.3.md Outdated Show resolved Hide resolved
@rmloveland rmloveland enabled auto-merge (squash) January 15, 2025 20:02
@rmloveland rmloveland merged commit 12a2ed4 into main Jan 15, 2025
7 checks passed
@rmloveland rmloveland deleted the release-notes-v25.1.0-alpha.3 branch January 15, 2025 20:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants