db: amend BenchmarkRangeDelIterate #1071
Merged
+79
−59
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change is |
jbowens
force-pushed
the
jackson/rangedel-benchmark
branch
from
b20c6f7 to
007862b
Compare
Amend BenchmarkRangeDelIterate to include benchmarks that iterate through keys that are deleted by a range tombstone within the same SSTable. See cockroachdb#1070. ``` goos: linux goarch: amd64 pkg: github.com/cockroachdb/pebble BenchmarkRangeDelIterate BenchmarkRangeDelIterate/entries=10 BenchmarkRangeDelIterate/entries=10/deleted=10 BenchmarkRangeDelIterate/entries=10/deleted=10/snapshotAndCompact=false BenchmarkRangeDelIterate/entries=10/deleted=10/snapshotAndCompact=false-24 1868349 636 ns/op BenchmarkRangeDelIterate/entries=10/deleted=10/snapshotAndCompact=true BenchmarkRangeDelIterate/entries=10/deleted=10/snapshotAndCompact=true-24 403632 2945 ns/op BenchmarkRangeDelIterate/entries=10/deleted=9 BenchmarkRangeDelIterate/entries=10/deleted=9/snapshotAndCompact=false BenchmarkRangeDelIterate/entries=10/deleted=9/snapshotAndCompact=false-24 647324 1855 ns/op BenchmarkRangeDelIterate/entries=10/deleted=9/snapshotAndCompact=true BenchmarkRangeDelIterate/entries=10/deleted=9/snapshotAndCompact=true-24 425908 2793 ns/op BenchmarkRangeDelIterate/entries=1000 BenchmarkRangeDelIterate/entries=1000/deleted=1000 BenchmarkRangeDelIterate/entries=1000/deleted=1000/snapshotAndCompact=false BenchmarkRangeDelIterate/entries=1000/deleted=1000/snapshotAndCompact=false-24 1874809 642 ns/op BenchmarkRangeDelIterate/entries=1000/deleted=1000/snapshotAndCompact=true BenchmarkRangeDelIterate/entries=1000/deleted=1000/snapshotAndCompact=true-24 10000 106763 ns/op BenchmarkRangeDelIterate/entries=1000/deleted=999 BenchmarkRangeDelIterate/entries=1000/deleted=999/snapshotAndCompact=false BenchmarkRangeDelIterate/entries=1000/deleted=999/snapshotAndCompact=false-24 613291 1895 ns/op BenchmarkRangeDelIterate/entries=1000/deleted=999/snapshotAndCompact=true BenchmarkRangeDelIterate/entries=1000/deleted=999/snapshotAndCompact=true-24 10000 106169 ns/op BenchmarkRangeDelIterate/entries=100000 BenchmarkRangeDelIterate/entries=100000/deleted=100000 BenchmarkRangeDelIterate/entries=100000/deleted=100000/snapshotAndCompact=false BenchmarkRangeDelIterate/entries=100000/deleted=100000/snapshotAndCompact=false-24 1865816 640 ns/op BenchmarkRangeDelIterate/entries=100000/deleted=100000/snapshotAndCompact=true BenchmarkRangeDelIterate/entries=100000/deleted=100000/snapshotAndCompact=true-24 106 10928184 ns/op BenchmarkRangeDelIterate/entries=100000/deleted=99999 BenchmarkRangeDelIterate/entries=100000/deleted=99999/snapshotAndCompact=false BenchmarkRangeDelIterate/entries=100000/deleted=99999/snapshotAndCompact=false-24 614889 1937 ns/op BenchmarkRangeDelIterate/entries=100000/deleted=99999/snapshotAndCompact=true BenchmarkRangeDelIterate/entries=100000/deleted=99999/snapshotAndCompact=true-24 105 10958571 ns/op ```
jbowens
force-pushed
the
jackson/rangedel-benchmark
branch
from
007862b to
82e23c9
Compare
itsbilal
approved these changes
Feb 25, 2021
There was a problem hiding this comment.
Reviewed 1 of 1 files at r1.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @petermattis and @sumeerbhola)
jbowens
commented
Feb 25, 2021
There was a problem hiding this comment.
TFTR!
Reviewable status:
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Amend BenchmarkRangeDelIterate to include benchmarks that iterate
through keys that are deleted by a range tombstone within the same
SSTable.
See #1070.