fix functions by using external parser lib #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The change to adopt 22.2 syntax broke sqlfumpt when using functions that are also mapped to sql syntax. The external parser library has logic to avoid this bug by rewriting some go logic related to WrapFunction. Using that library is better anyway. This allows us to avoid the replaced dependency.
knz
approved these changes
Dec 12, 2022
|
! This is so great! I have tried on and off for years to get the .mod fixes with cockroach-gen to work, and was then also sad about the huge amount of dependencies sqlfmt relied on in earlier years. I wonder if this makes the resulting binary small enough to dump into wasm now and avoid a backend completely. |
|
https://mjibson.github.io/sqlfmt/ is a working wasm version of this on github pages (fastly?). 7.8MB wasm file when gzipped. Kinda big but not terrible. I'm very curious about the performance impact on low-bandwidth users, but have no idea how to measure that. I may implement the remainder of the UI features and investigate moving over the main domain to it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The change to adopt 22.2 syntax broke sqlfumpt when using functions that are also mapped to sql syntax. The external parser library has logic to avoid this bug by rewriting some go logic related to WrapFunction. Using that library is better anyway. This allows us to avoid the replaced dependency.