Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fixed #16190: Compilation errors if using Clang 15 with c++17 since std::unary_function has been removed #16191

Merged
merged 2 commits into from
Sep 6, 2023
Merged

fixed #16190: Compilation errors if using Clang 15 with c++17 since std::unary_function has been removed #16191

merged 2 commits into from
Sep 6, 2023

Conversation

dumganhar
Copy link
Contributor

Re: #16190

Changelog

Continuous Integration

This pull request:

  • needs automatic test cases check.

    Manual trigger with @cocos-robot run test cases afterward.

  • does not change any runtime related code or build configuration

    If any reviewer thinks the CI checks are needed, please uncheck this option, then close and reopen the issue.

Compatibility Check

This pull request:

  • changes public API, and have ensured backward compatibility with deprecated features.
  • affects platform compatibility, e.g. system version, browser version, platform sdk version, platform toolchain, language version, hardware compatibility etc.
  • affects file structure of the build package or build configuration which requires user project upgrade.
  • introduces breaking changes, please list all changes, affected features and the scope of violation.

@dumganhar dumganhar requested a review from minggo September 5, 2023 10:19
@github-actions
Copy link

github-actions bot commented Sep 5, 2023

Interface Check Report

This pull request does not change any public interfaces !

@dumganhar dumganhar requested a review from minggo September 6, 2023 06:57
@minggo minggo merged commit 4b039cd into cocos:v3.8.2 Sep 6, 2023
dumganhar added a commit to dumganhar/cocos-engine that referenced this pull request Sep 21, 2023
@dumganhar
fixed cocos#16190: Compilation errors if using Clang 15 with c++17 si…
a236bba 
…nce std::unary_function has been removed (cocos#16191)

* fixed cocos#16190: Compilation errors if using Clang 15 with c++17 since std::unary_function has been removed

* Windows doesn't need to define BOOST_NO_CXX98_FUNCTION_BASE since it has already been defined.
minggo pushed a commit that referenced this pull request Sep 21, 2023
@dumganhar
Fix a compilation issue and a crash issue if using Xcode 15 (#16306)
8c3e160 
* Fix crash in __cxx_global_var_init if using Xcode 15 and targeting <= iOS 14

* fixed #16190: Compilation errors if using Clang 15 with c++17 since std::unary_function has been removed (#16191)

* fixed #16190: Compilation errors if using Clang 15 with c++17 since std::unary_function has been removed

* Windows doesn't need to define BOOST_NO_CXX98_FUNCTION_BASE since it has already been defined.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@minggo minggo minggo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dumganhar @minggo