refactor CocosActivity #16203
Merged
refactor CocosActivity #16203
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bofeng-song
commented
Sep 7, 2023
Interface Check ReportThis pull request does not change any public interfaces ! |
minggo
reviewed
Sep 7, 2023
minggo
reviewed
Sep 7, 2023
native/cocos/platform/android/java/src/com/cocos/lib/CocosEngine.java
Outdated
Show resolved
Hide resolved
minggo
reviewed
Sep 7, 2023
native/cocos/platform/android/java/src/com/cocos/lib/CocosAudio.java
Outdated
Show resolved
Hide resolved
minggo
reviewed
Sep 7, 2023
native/cocos/platform/android/java/src/com/cocos/lib/CocosEngine.java
Outdated
Show resolved
Hide resolved
minggo
reviewed
Sep 7, 2023
minggo
approved these changes
Sep 8, 2023
dumganhar
reviewed
Sep 8, 2023
dumganhar
reviewed
Sep 8, 2023
| mContext = null; | ||
| } | ||
|
|
||
| void init() { |
There was a problem hiding this comment.
When will init be invoked?
There was a problem hiding this comment.
It can be init at construct, but Actvity should be called after super.oncreate
There was a problem hiding this comment.
and call initWithView instead
dumganhar
reviewed
Sep 8, 2023
|
|
||
| void resume() { | ||
| mSensorHandler.onResume(); | ||
| Utils.hideVirtualButton(); |
There was a problem hiding this comment.
Utils.hideVirtualButton(); is invoked in CocosActivity.onResume, why do you have to invoke it here?
There was a problem hiding this comment.
Need to remove, it should be app's behavior
dumganhar
approved these changes
Sep 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Re: # #14626
Changelog
Continuous Integration
This pull request:
Compatibility Check
This pull request: