Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

do not create RenderDrawInfo every frame #16242

Closed
wants to merge 2 commits into from
Closed

do not create RenderDrawInfo every frame #16242

wants to merge 2 commits into from

Conversation

zxx43
Copy link
Contributor

@zxx43 zxx43 commented Sep 11, 2023

Re: #

Changelog


Continuous Integration

This pull request:

  • needs automatic test cases check.

    Manual trigger with @cocos-robot run test cases afterward.

  • does not change any runtime related code or build configuration

    If any reviewer thinks the CI checks are needed, please uncheck this option, then close and reopen the issue.


Compatibility Check

This pull request:

  • changes public API, and have ensured backward compatibility with deprecated features.
  • affects platform compatibility, e.g. system version, browser version, platform sdk version, platform toolchain, language version, hardware compatibility etc.
  • affects file structure of the build package or build configuration which requires user project upgrade.
  • introduces breaking changes, please list all changes, affected features and the scope of violation.

@zxx43 zxx43 requested a review from LinYunMo September 11, 2023 09:26
@github-actions
Copy link

github-actions bot commented Sep 11, 2023

Interface Check Report

! WARNING this pull request has changed these public interfaces:

@@ -59566,8 +59566,9 @@
             constructor(entityType: _cocos_2d_renderer_render_entity__RenderEntityType);
             addDynamicRenderDrawInfo(renderDrawInfo: _cocos_2d_renderer_render_draw_info__RenderDrawInfo | null): void;
             removeDynamicRenderDrawInfo(): void;
             clearDynamicRenderDrawInfos(): void;
+            getDynamicRenderDrawInfosLen(): number;
             clearStaticRenderDrawInfos(): void;
             setDynamicRenderDrawInfo(renderDrawInfo: _cocos_2d_renderer_render_draw_info__RenderDrawInfo | null, index: number): void;
             setMaskMode(mode: _cocos_2d_renderer_render_entity__MaskMode): void;
             getStaticRenderDrawInfo(): _cocos_2d_renderer_render_draw_info__RenderDrawInfo | null;

@minggo minggo requested a review from qiuguohua November 13, 2023 01:46
@@ -175,6 +175,14 @@ export class RenderEntity {
}
}

public getDynamicRenderDrawInfosLen (): number {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should private be used here?

@minggo minggo deleted the branch cocos:v3.8.2 May 16, 2024 02:52
@minggo minggo closed this May 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants