Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat:support xr controller a/b/x/y/trigger/thumbstick touch event #16293

Merged
merged 3 commits into from
Sep 26, 2023
Merged

feat:support xr controller a/b/x/y/trigger/thumbstick touch event #16293

merged 3 commits into from
Sep 26, 2023

Conversation

oahc09
Copy link
Contributor

@oahc09 oahc09 commented Sep 20, 2023 •
edited
Loading

Re: #

follow openxr spec:
https://registry.khronos.org/OpenXR/specs/1.0/html/xrspec.html#semantic-path-interaction-profiles

Changelog

Continuous Integration

This pull request:

  • needs automatic test cases check.

    Manual trigger with @cocos-robot run test cases afterward.

  • does not change any runtime related code or build configuration

    If any reviewer thinks the CI checks are needed, please uncheck this option, then close and reopen the issue.

Compatibility Check

This pull request:

  • changes public API, and have ensured backward compatibility with deprecated features.
  • affects platform compatibility, e.g. system version, browser version, platform sdk version, platform toolchain, language version, hardware compatibility etc.
  • affects file structure of the build package or build configuration which requires user project upgrade.
  • introduces breaking changes, please list all changes, affected features and the scope of violation.

@github-actions
Copy link

Interface Check Report

This pull request does not change any public interfaces !

@oahc09 oahc09 marked this pull request as ready for review September 21, 2023 03:33
@oahc09 oahc09 closed this Sep 21, 2023
@oahc09 oahc09 reopened this Sep 21, 2023
@fqamic fqamic assigned fqamic and unassigned fqamic Sep 22, 2023
@oahc09 oahc09 requested a review from minggo September 25, 2023 01:04
@minggo minggo requested a review from PatriceJiang September 25, 2023 01:38
PatriceJiang
PatriceJiang reviewed Sep 26, 2023
View reviewed changes
native/cocos/engine/EngineEvents.h
@@ -126,6 +126,18 @@ enum class StickAxisCode {
RIGHT_GRIP,
};

enum class StickTouchCode {
UNDEFINE = 0,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

UNDEFINED?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same as StickKeyCode:UNDEFINE / StickAxisCode::UNDEFINE

@minggo minggo merged commit 2928e74 into cocos:v3.8.2 Sep 26, 2023
24 checks passed
@oahc09 oahc09 deleted the v382-xr-input branch October 9, 2023 06:37
@oahc09 oahc09 restored the v382-xr-input branch October 9, 2023 06:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PatriceJiang PatriceJiang PatriceJiang approved these changes

@PPpro PPpro PPpro approved these changes

@QingliWang QingliWang QingliWang approved these changes

@fqamic fqamic fqamic approved these changes

@minggo minggo minggo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@oahc09 @minggo @fqamic @QingliWang @PPpro @PatriceJiang