Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

correct renderpass reorder logic #16294

Merged
merged 5 commits into from
Sep 21, 2023
Merged

correct renderpass reorder logic #16294

merged 5 commits into from
Sep 21, 2023

Conversation

hana-alice
Copy link
Contributor

Re: #

Changelog

  • won't reorder attachment index when
    • it's a single render pass;
    • it has and only has 1 subpass;

Continuous Integration

This pull request:

  • needs automatic test cases check.

    Manual trigger with @cocos-robot run test cases afterward.

  • does not change any runtime related code or build configuration

    If any reviewer thinks the CI checks are needed, please uncheck this option, then close and reopen the issue.


Compatibility Check

This pull request:

  • changes public API, and have ensured backward compatibility with deprecated features.
  • affects platform compatibility, e.g. system version, browser version, platform sdk version, platform toolchain, language version, hardware compatibility etc.
  • affects file structure of the build package or build configuration which requires user project upgrade.
  • introduces breaking changes, please list all changes, affected features and the scope of violation.

@github-actions
Copy link

Interface Check Report

This pull request does not change any public interfaces !

@hana-alice hana-alice requested a review from star-e September 21, 2023 03:12
@star-e star-e merged commit 2039c33 into cocos:v3.8.1 Sep 21, 2023
21 of 23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants