Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix a compilation issue and a crash issue if using Xcode 15 #16306

Merged
merged 2 commits into from
Sep 21, 2023
Merged

Fix a compilation issue and a crash issue if using Xcode 15 #16306

merged 2 commits into from
Sep 21, 2023

Conversation

dumganhar
Copy link
Contributor

Re: # #16190

Changelog

Continuous Integration

This pull request:

  • needs automatic test cases check.

    Manual trigger with @cocos-robot run test cases afterward.

  • does not change any runtime related code or build configuration

    If any reviewer thinks the CI checks are needed, please uncheck this option, then close and reopen the issue.

Compatibility Check

This pull request:

  • changes public API, and have ensured backward compatibility with deprecated features.
  • affects platform compatibility, e.g. system version, browser version, platform sdk version, platform toolchain, language version, hardware compatibility etc.
  • affects file structure of the build package or build configuration which requires user project upgrade.
  • introduces breaking changes, please list all changes, affected features and the scope of violation.

@dumganhar
Fix crash in __cxx_global_var_init if using Xcode 15 and targeting <=…
53fa956 
… iOS 14
@dumganhar
fixed cocos#16190: Compilation errors if using Clang 15 with c++17 si…
a236bba 
…nce std::unary_function has been removed (cocos#16191)

* fixed cocos#16190: Compilation errors if using Clang 15 with c++17 since std::unary_function has been removed

* Windows doesn't need to define BOOST_NO_CXX98_FUNCTION_BASE since it has already been defined.
@dumganhar dumganhar mentioned this pull request Sep 21, 2023
Closed
@dumganhar dumganhar changed the title Fix an compilation issue and a crash issue if using Xcode 15 Fix a compilation issue and a crash issue if using Xcode 15 Sep 21, 2023
@github-actions
Copy link

Interface Check Report

This pull request does not change any public interfaces !

@minggo minggo merged commit 8c3e160 into cocos:v3.8.1 Sep 21, 2023
25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PatriceJiang PatriceJiang PatriceJiang approved these changes

@minggo minggo minggo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dumganhar @minggo @PatriceJiang