Fix the issue of update the wrapMode after changing the image type #16315
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nianba23
commented
Sep 22, 2023
Interface Check ReportThis pull request does not change any public interfaces ! |
nianba23
changed the title
yanOO1497
approved these changes
Sep 22, 2023
…x-change-wrapMode
VisualSJ
reviewed
Oct 9, 2023
| @@ -413,7 +413,9 @@ const Elements = { | |||
| // 根据 wrapModeSelect 组合值同步相应的 wrapModeS/wrapModeT 到 userData | |||
| const value = event.target.value; | |||
| // 临时记录用户的修改配置 | |||
| Editor.Profile.setConfig('inspector', `${this.meta.uuid}.texture.wrapMode`, value, 'default'); | |||
| this.metaList && this.metaList.forEach((meta) => { | |||
| Editor.Profile.setConfig('inspector', `${meta.uuid}.texture.wrapMode`, value, 'default'); | |||
There was a problem hiding this comment.
Is this data for the interface temporary? Would it be better to put it in 'Temp'?
这个数据是界面用的临时数据吧？放到 Temp 会不会更好？
There was a problem hiding this comment.
Temporary data is stored in the 'default' and is only valid for the current session. It won't be remembered next time. So, there is no need to store it in 'temp' for long-term recording.
VisualSJ
reviewed
Oct 9, 2023
VisualSJ
approved these changes
Oct 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Re: #
https://github.com/cocos/3d-tasks/issues/15635
Changelog
Continuous Integration
This pull request:
Compatibility Check
This pull request: