Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add bias for planar shadow #16316

Merged

Conversation

troublemaker52025
Copy link
Contributor

@troublemaker52025 troublemaker52025 commented Sep 22, 2023

Re: #

Changelog


Continuous Integration

This pull request:

  • needs automatic test cases check.

    Manual trigger with @cocos-robot run test cases afterward.

  • does not change any runtime related code or build configuration

    If any reviewer thinks the CI checks are needed, please uncheck this option, then close and reopen the issue.


Compatibility Check

This pull request:

  • changes public API, and have ensured backward compatibility with deprecated features.
  • affects platform compatibility, e.g. system version, browser version, platform sdk version, platform toolchain, language version, hardware compatibility etc.
  • affects file structure of the build package or build configuration which requires user project upgrade.
  • introduces breaking changes, please list all changes, affected features and the scope of violation.

@troublemaker52025
Copy link
Contributor Author

@cocos-robot run test cases

@github-actions
Copy link

Interface Check Report

! WARNING this pull request has changed these public interfaces:

@@ -11935,8 +11935,14 @@
                  */
                 get distance(): number;
                 set distance(val: number);
                 /**
+                 * @en Positional offset values in planar shading calculations.
+                 * @zh 平面阴影计算中的位置偏移值。
+                 */
+                get planeBias(): number;
+                set planeBias(val: number);
+                /**
                  * @en Shadow color.
                  * @zh 阴影颜色。
                  */
                 get shadowColor(): math.Color;
@@ -11975,8 +11981,9 @@
                 protected _instancingMaterial: Material | null;
                 protected _enabled: boolean;
                 protected _type: number;
                 protected _distance: number;
+                protected _planeBias: number;
                 protected _normal: math.Vec3;
                 protected _shadowColor: math.Color;
                 protected _size: math.Vec2;
                 protected _shadowMapDirty: boolean;
@@ -26431,8 +26438,14 @@
          */
         set planeHeight(val: number);
         get planeHeight(): number;
         /**
+         * @en Positional offset values in planar shading calculations.
+         * @zh 平面阴影计算中的位置偏移值。
+         */
+        set planeBias(val: number);
+        get planeBias(): number;
+        /**
          * @en get or set shadow max received
          * @zh 获取或者设置阴影接收的最大光源数量
          */
         set maxReceived(val: number);
@@ -26446,8 +26459,9 @@
         protected _enabled: boolean;
         protected _type: number;
         protected _normal: math.Vec3;
         protected _distance: number;
+        protected _planeBias: number;
         protected _shadowColor: math.Color;
         protected _maxReceived: number;
         protected _size: math.Vec2;
         protected _resource: renderer.scene.Shadows | null;

@jk20012001 jk20012001 merged commit b0c25b0 into cocos:v3.8.2 Oct 16, 2023
24 checks passed
cocos-robot pushed a commit to cocos-robot/engine that referenced this pull request Oct 16, 2023
minggo pushed a commit that referenced this pull request Oct 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants