Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat:add imutable texture flag for Webgl2 #16332

Merged
merged 2 commits into from
Oct 9, 2023
Merged

Conversation

bluesky013
Copy link
Contributor

@bluesky013 bluesky013 commented Sep 26, 2023

backport from develop
#15250

Changelog
feat:add imutable texture flag for Webgl2


Continuous Integration

This pull request:

  • needs automatic test cases check.

    Manual trigger with @cocos-robot run test cases afterward.

  • does not change any runtime related code or build configuration

    If any reviewer thinks the CI checks are needed, please uncheck this option, then close and reopen the issue.


Compatibility Check

This pull request:

  • changes public API, and have ensured backward compatibility with deprecated features.
  • affects platform compatibility, e.g. system version, browser version, platform sdk version, platform toolchain, language version, hardware compatibility etc.
  • affects file structure of the build package or build configuration which requires user project upgrade.
  • introduces breaking changes, please list all changes, affected features and the scope of violation.

@bluesky013
Copy link
Contributor Author

@cocos-robot run test cases

@bluesky013
Copy link
Contributor Author

#16239

@github-actions
Copy link

Interface Check Report

! WARNING this pull request has changed these public interfaces:

@@ -8495,9 +8495,10 @@
             GENERAL_LAYOUT = 2,
             EXTERNAL_OES = 4,
             EXTERNAL_NORMAL = 8,
             LAZILY_ALLOCATED = 16,
-            MUTABLE_VIEW_FORMAT = 64
+            MUTABLE_VIEW_FORMAT = 64,
+            MUTABLE_STORAGE = 128
         }
         export enum FormatFeatureBit {
             NONE = 0,
             RENDER_TARGET = 1,

@bluesky013 bluesky013 requested a review from star-e September 26, 2023 01:36
@bluesky013 bluesky013 closed this Sep 26, 2023
@bluesky013 bluesky013 reopened this Sep 26, 2023
@sushanhong
Copy link
Contributor

@cocos-robot run test cases

1 similar comment
@sushanhong
Copy link
Contributor

@cocos-robot run test cases

@github-actions
Copy link

github-actions bot commented Oct 7, 2023

@bluesky013, Please check the result of run test cases:

Task Details

@bluesky013 bluesky013 closed this Oct 9, 2023
@bluesky013 bluesky013 reopened this Oct 9, 2023
@github-actions
Copy link

github-actions bot commented Oct 9, 2023

@bluesky013, Please check the result of run test cases:

Task Details

@bluesky013
Copy link
Contributor Author

@cocos-robot run test cases

@star-e star-e merged commit ac4ff38 into cocos:v3.8.2 Oct 9, 2023
24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants