Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the problem that the editbox shifts too far away when the keyboard pops up #16461

Merged
merged 3 commits into from
Nov 8, 2023

Conversation

bofeng-song
Copy link
Contributor

@bofeng-song bofeng-song commented Nov 2, 2023

Re: # #16462

Changelog


Continuous Integration

This pull request:

  • needs automatic test cases check.

    Manual trigger with @cocos-robot run test cases afterward.

  • does not change any runtime related code or build configuration

    If any reviewer thinks the CI checks are needed, please uncheck this option, then close and reopen the issue.


Compatibility Check

This pull request:

  • changes public API, and have ensured backward compatibility with deprecated features.
  • affects platform compatibility, e.g. system version, browser version, platform sdk version, platform toolchain, language version, hardware compatibility etc.
  • affects file structure of the build package or build configuration which requires user project upgrade.
  • introduces breaking changes, please list all changes, affected features and the scope of violation.

@bofeng-song bofeng-song requested a review from minggo November 2, 2023 08:23
Copy link

github-actions bot commented Nov 2, 2023

Interface Check Report

This pull request does not change any public interfaces !

@@ -220,6 +220,13 @@ public void onGlobalLayout() {
if (!keyboardVisible) {
keyboardVisible = true;
}
int bottomOffset = 0;
if (Build.VERSION.SDK_INT >= Build.VERSION_CODES.M) {
bottomOffset = getWindow().getDecorView().getRootWindowInsets().getSystemWindowInsetBottom();
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

On devices with higher API levels, the system will handle the displacement of the rootView itself. Devices that have been processed will modify the bottom value in mFrameOffsets. In the source code, the bottom value corresponds to getSystemWindowInsetBottom.

@minggo minggo merged commit 7d3ab9e into cocos:v3.8.2 Nov 8, 2023
23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants