-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix spine can not show normally or crash #16528
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bofeng-song
commented
Nov 22, 2023
@@ -10,12 +10,6 @@ void SpineSkeletonSystem::updateAnimation(float deltaTime) { | |||
auto count = static_cast<int>(vectorSpines.size()); | |||
for (int i = count - 1; i >= 0; --i) { | |||
SpineSkeletonInstance* spineInstance = vectorSpines[i]; | |||
if(spineInstance->isDelete) { | |||
std::swap(spineInstance, vectorSpines.back()); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
spineInstance's value will be set to vectorSpines.back(), and delete spineInstance operation will trigger the last element of the vector to destroy
Interface Check Report! WARNING this pull request has changed these public interfaces:
@@ -51732,8 +51732,9 @@
transform(x: number, y: number): void;
end(): void;
}
export class SkeletonSystem {
+ public static destroySpineInstance(instance: SkeletonInstance): void;
public static updateAnimation(deltaTime: number): void;
public static updateRenderData(): void;
public static getCount(): number;
}
@@ -51770,9 +51771,8 @@
static createSpineSkeletonDataWithJson(jsonStr: string, atlasText: string): SkeletonData;
static createSpineSkeletonDataWithBinary(byteSize: number, atlasText: string): SkeletonData;
static registerSpineSkeletonDataWithUUID(data: SkeletonData, uuid: string);
static destroySpineSkeletonDataWithUUID(uuid: string);
- static destroySpineInstance(instance: SkeletonInstance);
static getCurrentListenerID(): number;
static getCurrentEventType(): EventType;
static getCurrentTrackEntry(): TrackEntry;
static getCurrentEvent(): Event;
|
minggo
reviewed
Nov 22, 2023
minggo
approved these changes
Nov 23, 2023
dumganhar
approved these changes
Nov 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Re: #
cocos/cocos-engine-external#444
https://github.com/cocos/3d-tasks/issues/17871
https://github.com/cocos/3d-tasks/issues/17870
https://github.com/cocos/3d-tasks/issues/17869
Changelog
Continuous Integration
This pull request:
Compatibility Check
This pull request: