Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix spine can not show normally or crash #16528

Merged
merged 3 commits into from
Nov 23, 2023
Merged

Conversation

bofeng-song
Copy link
Contributor

@bofeng-song bofeng-song commented Nov 22, 2023

Re: #
cocos/cocos-engine-external#444
https://github.com/cocos/3d-tasks/issues/17871
https://github.com/cocos/3d-tasks/issues/17870
https://github.com/cocos/3d-tasks/issues/17869

Changelog


Continuous Integration

This pull request:

  • needs automatic test cases check.

    Manual trigger with @cocos-robot run test cases afterward.

  • does not change any runtime related code or build configuration

    If any reviewer thinks the CI checks are needed, please uncheck this option, then close and reopen the issue.


Compatibility Check

This pull request:

  • changes public API, and have ensured backward compatibility with deprecated features.
  • affects platform compatibility, e.g. system version, browser version, platform sdk version, platform toolchain, language version, hardware compatibility etc.
  • affects file structure of the build package or build configuration which requires user project upgrade.
  • introduces breaking changes, please list all changes, affected features and the scope of violation.

@bofeng-song bofeng-song requested a review from minggo November 22, 2023 08:44
@@ -10,12 +10,6 @@ void SpineSkeletonSystem::updateAnimation(float deltaTime) {
auto count = static_cast<int>(vectorSpines.size());
for (int i = count - 1; i >= 0; --i) {
SpineSkeletonInstance* spineInstance = vectorSpines[i];
if(spineInstance->isDelete) {
std::swap(spineInstance, vectorSpines.back());
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

spineInstance's value will be set to vectorSpines.back(), and delete spineInstance operation will trigger the last element of the vector to destroy

Copy link

github-actions bot commented Nov 22, 2023

Interface Check Report

! WARNING this pull request has changed these public interfaces:

@@ -51732,8 +51732,9 @@
                 transform(x: number, y: number): void;
                 end(): void;
             }
             export class SkeletonSystem {
+                public static destroySpineInstance(instance: SkeletonInstance): void;
                 public static updateAnimation(deltaTime: number): void;
                 public static updateRenderData(): void;
                 public static getCount(): number;
             }
@@ -51770,9 +51771,8 @@
                 static createSpineSkeletonDataWithJson(jsonStr: string, atlasText: string): SkeletonData;
                 static createSpineSkeletonDataWithBinary(byteSize: number, atlasText: string): SkeletonData;
                 static registerSpineSkeletonDataWithUUID(data: SkeletonData, uuid: string);
                 static destroySpineSkeletonDataWithUUID(uuid: string);
-                static destroySpineInstance(instance: SkeletonInstance);
                 static getCurrentListenerID(): number;
                 static getCurrentEventType(): EventType;
                 static getCurrentTrackEntry(): TrackEntry;
                 static getCurrentEvent(): Event;

@minggo minggo merged commit f5ca599 into cocos:v3.8.2 Nov 23, 2023
23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants