Refine: make multi skeleton component shared one instance of spine.Skeleton while spine working at sharedCache mode #16593
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
minggo
reviewed
Dec 12, 2023
native/cocos/editor-support/spine-wasm/spine-skeleton-instance.cpp
Outdated
Show resolved
Hide resolved
minggo
reviewed
Dec 12, 2023
minggo
reviewed
Dec 12, 2023
| } | ||
|
|
||
| void SpineSkeletonInstance::release() { | ||
| --_referenceCount; |
There was a problem hiding this comment.
It is better to assert _referenceCount > 0.
…eleton while spine working at sharedCache mode
bofeng-song
changed the title
Interface Check Report! WARNING this pull request has changed these public interfaces:
@@ -52023,8 +52023,9 @@
static createSpineSkeletonDataWithJson(jsonStr: string, atlasText: string): SkeletonData;
static createSpineSkeletonDataWithBinary(byteSize: number, atlasText: string): SkeletonData;
static registerSpineSkeletonDataWithUUID(data: SkeletonData, uuid: string);
static destroySpineSkeletonDataWithUUID(uuid: string);
+ static destroySpineSkeleton(skeleton: Skeleton): void;
static getCurrentListenerID(): number;
static getCurrentEventType(): EventType;
static getCurrentTrackEntry(): TrackEntry;
static getCurrentEvent(): Event;
@@ -67477,8 +67478,9 @@
curAnimationCache: _cocos_spine_skeleton_cache__AnimationCache | null;
animationsCache: {
[key: string]: _cocos_spine_skeleton_cache__AnimationCache;
};
+ assetUUID: string;
}
export class _cocos_spine_skeleton_cache__SkeletonCache {
static readonly FrameTime: number;
static sharedCache: _cocos_spine_skeleton_cache__SkeletonCache;
@@ -67492,10 +67494,11 @@
constructor();
enablePrivateMode(): void;
clear(): void;
invalidAnimationCache(uuid: string): void;
- removeSkeleton(uuid: string): void;
- getSkeletonCache(uuid: string, skeletonData: sp.spine.SkeletonData): _cocos_spine_skeleton_cache__SkeletonCacheItemInfo;
+ destroySkeleton(assetUuid: string): void;
+ createSkeletonInfo(skeletonAsset: sp.SkeletonData): _cocos_spine_skeleton_cache__SkeletonCacheItemInfo;
+ getSkeletonInfo(skeletonAsset: sp.SkeletonData): null | _cocos_spine_skeleton_cache__SkeletonCacheItemInfo;
getAnimationCache(uuid: string, animationName: string): null | _cocos_spine_skeleton_cache__AnimationCache;
initAnimationCache(uuid: string, data: sp.SkeletonData, animationName: string): null | _cocos_spine_skeleton_cache__AnimationCache;
destroyCachedAnimations(uuid?: string): void;
}
|
dumganhar
reviewed
Dec 14, 2023
| this._animationPool[`${uuid}#${aniKey}`] = animationCache; | ||
| animationCache.clear(); | ||
| }; | ||
| const privateOperate = (aniKey: string, animationCache: AnimationCache): void => { |
There was a problem hiding this comment.
Why is it called privateOperate? What does private mean here?
There was a problem hiding this comment.
private corresponds to privateCache mode.
dumganhar
reviewed
Dec 14, 2023
cocos/spine/skeleton-cache.ts
Outdated
| let skeletonInfo = this._skeletonCache[uuid]; | ||
| if (!skeletonInfo) { | ||
| const skeleton = null; | ||
| const skeleton = new spine.Skeleton(skeletonData); |
There was a problem hiding this comment.
skeleton is forever null in the old code?
There was a problem hiding this comment.
skeleton will constructor by skeleton component's _instance in old code
There was a problem hiding this comment.
So we move the spine.Skeleton construction code to here?
There was a problem hiding this comment.
Yes, previous logic multi skeleton component can not share the same object of spine.skeleton
dumganhar
approved these changes
Dec 15, 2023
minggo
approved these changes
Dec 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Re: #
cocos/cocos-engine-external#449
#16598
Changelog
Continuous Integration
This pull request:
Compatibility Check
This pull request: