-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix spine can not be paused while working at realTime mode #16672
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dumganhar
reviewed
Jan 9, 2024
dumganhar
reviewed
Jan 9, 2024
@@ -34,7 +33,6 @@ static void trackEntryCallback(AnimationState *state, EventType type, TrackEntry | |||
|
|||
SpineSkeletonInstance::SpineSkeletonInstance() { | |||
_model = new SpineModel(); | |||
SpineSkeletonSystem::addSpineInstance(this); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why delete SpineSkeletonSystem ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Its no need an additional helper class to release the spineSkeletonInstance object.
Interface Check Report! WARNING this pull request has changed these public interfaces:
@@ -52001,8 +52001,9 @@
isCache: boolean;
isDelete: boolean;
enable: boolean;
setTrackEntryListener: any;
+ destroy();
initSkeleton(data: SkeletonData);
getAnimationState();
setAnimation(trackIndex: number, name: string, loop: boolean): spine.TrackEntry | null;
setSkin(name: string);
@@ -52204,9 +52205,9 @@
protected _debugSlots: boolean;
protected _enableBatch: boolean;
protected _runtimeData: spine.SkeletonData | null;
_skeleton: spine.Skeleton;
- protected _instance: spine.SkeletonInstance;
+ protected _instance: spine.SkeletonInstance | null;
protected _state: spine.AnimationState;
protected _textures: Texture2D[];
protected _animationName: string;
protected _skinName: string;
@@ -67448,9 +67449,9 @@
model: _cocos_spine_skeleton_cache__SpineModel;
boneInfos: _cocos_spine_skeleton_cache__FrameBoneInfo[];
}
export class _cocos_spine_skeleton_cache__AnimationCache {
- protected _instance: sp.spine.SkeletonInstance;
+ protected _instance: sp.spine.SkeletonInstance | null;
protected _state: sp.spine.AnimationState;
protected _skeletonData: sp.spine.SkeletonData;
protected _skeleton: sp.spine.Skeleton;
_privateMode: boolean;
|
dumganhar
approved these changes
Jan 9, 2024
minggo
approved these changes
Jan 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Re: #
#16661
cocos/cocos-engine-external#450
Changelog
Continuous Integration
This pull request:
Compatibility Check
This pull request: