fix a few errors in VKCommandBuffer.cpp #16731
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Interface Check ReportThis pull request does not change any public interfaces ! |
star-e
reviewed
Feb 19, 2024
star-e
reviewed
Feb 19, 2024
Comment on lines
+968
to
+969
| vkCmdPipelineBarrier(_gpuCommandBuffer->vkCommandBuffer, fullSrcStageMask, fullDstStageMask, 0, pMemoryBarrier ? 1 : 0, | ||
| pMemoryBarrier, fullBufferBarriers.size(), fullBufferBarriers.data(), fullImageBarriers.size(), fullImageBarriers.data()); |
There was a problem hiding this comment.
Shall we change the if (!fullBufferBarriers.empty() || !fullImageBarriers.empty()) to if (!fullBufferBarriers.empty() || !fullImageBarriers.empty() || pMemoryBarrier) ?
pMemoryBarrier might not be executed.
There was a problem hiding this comment.
personally i think it's fine, because memoryBarrierCount arg for vkCmdPipelineBarrier decides it will be used or not.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
1, should be Access mask, not Image layout
2, the ASSERT is useless because it's already tested above in the
missedvalue3, same with item 1
4,
uint32_t memoryBarrierCountshould not be 0 whenpMemoryBarrieris not null