check max mipmap level for texture creation #16783
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Interface Check ReportThis pull request does not change any public interfaces ! |
minggo
reviewed
Apr 17, 2024
| @@ -104,7 +104,8 @@ void TextureValidator::doInit(const TextureInfo &info) { | |||
| } | |||
|
|
|||
| if (hasFlag(info.flags, TextureFlagBit::GEN_MIPMAP)) { | |||
| CC_ASSERT(info.levelCount > 1); | |||
| auto maxLevelCount = std::floor(std::log2(std::max({ info.width, info.height, info.depth }))) + 1; | |||
There was a problem hiding this comment.
I think don't have to +1 for some situations, for example std::max({ info.width, info.height, info.depth }) == 8.
There was a problem hiding this comment.
check here:
cocos-engine/native/cocos/renderer/gfx-base/GFXTexture.cpp
Lines 84 to 86 in cde48d1
and this method actually could be moved to somewhere for common use.
There was a problem hiding this comment.
Got it, I think it is better to use _actor->getLevelCount() to get the value. And we may fix the logic of _actor->getLevelCount() in future.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
check max level count
actually there is already a function
getLevelCountin theGFXTexture.cppto calculate the max count, but i didn't move this function to somewhere for common use because not sure where should i put it.