Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix missing constructor for spine.String & SkeletonBounds #17376

Merged
merged 7 commits into from
Jul 18, 2024

Conversation

bofeng-song
Copy link
Contributor

@bofeng-song bofeng-song commented Jul 17, 2024

Re: #
#17002
cocos/cocos-engine-external#453

Changelog


Continuous Integration

This pull request:

  • needs automatic test cases check.

    Manual trigger with @cocos-robot run test cases afterward.

  • does not change any runtime related code or build configuration

    If any reviewer thinks the CI checks are needed, please uncheck this option, then close and reopen the issue.


Compatibility Check

This pull request:

  • changes public API, and have ensured backward compatibility with deprecated features.
  • affects platform compatibility, e.g. system version, browser version, platform sdk version, platform toolchain, language version, hardware compatibility etc.
  • affects file structure of the build package or build configuration which requires user project upgrade.
  • introduces breaking changes, please list all changes, affected features and the scope of violation.

@bofeng-song bofeng-song requested a review from minggo July 17, 2024 03:09
Copy link

github-actions bot commented Jul 17, 2024

Interface Check Report

! WARNING this pull request has changed these public interfaces:

@@ -51250,8 +51250,10 @@
          */
         /* eslint @typescript-eslint/no-explicit-any: "off" */
         export namespace spine {
             export class String {
+                constructor(name: string, own: boolean);
+                constructor(val: spine.String);
                 length: number;
                 isEmpty: boolean;
                 strPtr: number;
                 str: string;

@minggo minggo merged commit c710991 into cocos:v3.8.4 Jul 18, 2024
23 of 24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants