Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing the SkeletonData export error. #17520

Merged
merged 2 commits into from
Aug 12, 2024
Merged

Fixing the SkeletonData export error. #17520

merged 2 commits into from
Aug 12, 2024

Conversation

bofeng-song
Copy link
Contributor

@bofeng-song bofeng-song commented Aug 9, 2024

Re: #
cocos/cocos-engine-external#457

Changelog


Continuous Integration

This pull request:

  • needs automatic test cases check.

    Manual trigger with @cocos-robot run test cases afterward.

  • does not change any runtime related code or build configuration

    If any reviewer thinks the CI checks are needed, please uncheck this option, then close and reopen the issue.


Compatibility Check

This pull request:

  • changes public API, and have ensured backward compatibility with deprecated features.
  • affects platform compatibility, e.g. system version, browser version, platform sdk version, platform toolchain, language version, hardware compatibility etc.
  • affects file structure of the build package or build configuration which requires user project upgrade.
  • introduces breaking changes, please list all changes, affected features and the scope of violation.

Greptile Summary

The pull request addresses the SkeletonData export error by modifying the build configuration and updating the Spine WASM bindings.

  • Build Configuration: Changed build type to 'MinSizeRel' in /native/cocos/editor-support/spine-wasm/CMakeLists.txt to reduce WebAssembly binary size.
  • New Vector Types: Added vector types for SlotData, TransformConstraintData, and PathConstraintData in /native/cocos/editor-support/spine-wasm/spine-type-export.cpp.
  • EMSCRIPTEN_BINDINGS Update: Updated EMSCRIPTEN_BINDINGS to include the new vector types in /native/cocos/editor-support/spine-wasm/spine-type-export.cpp.
  • External Config Update: Updated /native/external-config.json to use engine-native-external version v3.8.4-5.

Ensure all tests pass to verify the changes.

Copy link

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

2 file(s) reviewed, no comment(s)
Edit PR Review Bot Settings

@bofeng-song bofeng-song requested a review from minggo August 9, 2024 07:19
Copy link

github-actions bot commented Aug 9, 2024

Interface Check Report

This pull request does not change any public interfaces !

Copy link

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

1 file(s) reviewed, no comment(s)
Edit PR Review Bot Settings

@minggo minggo merged commit 3b8a65e into cocos:v3.8.4 Aug 12, 2024
24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants