Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RenderPass now considers clearColor #17530

Merged
merged 1 commit into from
Aug 13, 2024
Merged

Conversation

star-e
Copy link
Contributor

@star-e star-e commented Aug 12, 2024

https://github.com/cocos/3d-tasks/issues/18404

Fix ui-fill-z

Currently, vulkan dynamic states is not supported, as a result, different clear color must has different render pass.

Changelog


Continuous Integration

This pull request:

  • needs automatic test cases check.

    Manual trigger with @cocos-robot run test cases afterward.

  • does not change any runtime related code or build configuration

    If any reviewer thinks the CI checks are needed, please uncheck this option, then close and reopen the issue.


Compatibility Check

This pull request:

  • changes public API, and have ensured backward compatibility with deprecated features.
  • affects platform compatibility, e.g. system version, browser version, platform sdk version, platform toolchain, language version, hardware compatibility etc.
  • affects file structure of the build package or build configuration which requires user project upgrade.
  • introduces breaking changes, please list all changes, affected features and the scope of violation.

Greptile Summary

The pull request introduces changes to ensure that clearColor is considered in render passes, which is crucial for differentiating them based on their clear color.

  • Added clearColor attribute to RasterView in native/cocos/renderer/pipeline/custom/RenderGraphTypes.h.
  • Updated hash function for RasterView to include clearColor.
  • Introduced a new specialization of the Hasher template for the Color struct in native/cocos/renderer/gfx-base/GFXDef.cpp.
  • Ensured Color objects can be hashed consistently using quickHashTrivialStruct.

These changes are essential for handling Vulkan dynamic states and ensuring accurate render pass differentiation.

Copy link

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

2 file(s) reviewed, no comment(s)
Edit PR Review Bot Settings

Copy link

Interface Check Report

This pull request does not change any public interfaces !

@star-e star-e requested a review from minggo August 12, 2024 10:05
@minggo minggo merged commit 79c28d6 into cocos:v3.8.4 Aug 13, 2024
25 checks passed
@star-e star-e deleted the v3.8.4-renderpass branch August 13, 2024 03:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants