Fix the order of callback by performFunctionInCocosThread and add unit-test for it. #17543

dumganhar · 2024-08-15T09:51:31Z

Re: #17012, #17464

Changelog

Continuous Integration

This pull request:

needs automatic test cases check.

Manual trigger with @cocos-robot run test cases afterward.
does not change any runtime related code or build configuration

If any reviewer thinks the CI checks are needed, please uncheck this option, then close and reopen the issue.

Compatibility Check

This pull request:

changes public API, and have ensured backward compatibility with deprecated features.
affects platform compatibility, e.g. system version, browser version, platform sdk version, platform toolchain, language version, hardware compatibility etc.
affects file structure of the build package or build configuration which requires user project upgrade.
introduces breaking changes, please list all changes, affected features and the scope of violation.

Greptile Summary

This pull request modifies the performInCocosThreadOrder test in native/tests/unit-test/src/scheduler_test.cpp to improve the validation of task execution order in the Scheduler.

Updated test to use std::shared_ptr<Scheduler> for better memory management
Modified lambda capture to ensure scheduler remains valid throughout task execution
Changed result comparison from EXPECT_EQ to EXPECT_TRUE with direct vector comparison
Potential thread safety issue introduced, as the shared_ptr is captured by value in the lambda

…t-test for it. Re: cocos#17012, cocos#17464

greptile-apps

LGTM

_{2 file(s) reviewed, no comment(s)}
_{Edit PR Review Bot Settings}

greptile-apps

LGTM

_{1 file(s) reviewed, no comment(s)}
_{Edit PR Review Bot Settings}

github-actions · 2024-08-15T10:05:15Z

Interface Check Report

This pull request does not change any public interfaces !

greptile-apps

LGTM

_{1 file(s) reviewed, no comment(s)}
_{Edit PR Review Bot Settings}

greptile-apps

LGTM

_{1 file(s) reviewed, no comment(s)}
_{Edit PR Review Bot Settings}

greptile-apps

LGTM

_{1 file(s) reviewed, no comment(s)}
_{Edit PR Review Bot Settings}

[ RUN ] schedulerTest.performInCocosThreadOrder unknown file: error: SEH exception with code 0xc0000005 thrown in the test body. [ FAILED ] schedulerTest.performInCocosThreadOrder (0 ms)

greptile-apps

_{25 file(s) reviewed, 4 comment(s)}
_{Edit PR Review Bot Settings}

greptile-apps · 2024-08-16T03:11:50Z

native/tests/unit-test/src/core_utils_path_test.cpp

logic: Removing all unit tests for path utilities may reduce test coverage. Ensure these tests are either no longer needed or have been moved elsewhere.

greptile-apps · 2024-08-16T03:13:46Z

native/tests/unit-test/src/math_geometry_test.cpp

logic: Removing all geometry tests may reduce test coverage. Ensure these tests are either replaced or no longer necessary.

greptile-apps · 2024-08-16T03:14:13Z

native/tests/unit-test/src/math_mat3_test.cpp

logic: Removing all Mat3 unit tests may reduce code coverage and make it harder to catch regressions in future changes to the Mat3 class. Ensure these tests are either relocated or replaced with equivalent tests elsewhere.

greptile-apps · 2024-08-16T03:15:31Z

native/tests/unit-test/src/math_utils_test.cpp

logic: Removing all math utility tests may reduce test coverage for critical mathematical operations. Ensure these tests are either relocated or replaced with equivalent tests elsewhere.

This reverts commit 2739895.

This reverts commit 07beedc.

This reverts commit 88e0adc.

…r: no such file or directory: '$(inherited)'

greptile-apps

_{26 file(s) reviewed, 1 comment(s)}
_{Edit PR Review Bot Settings}

greptile-apps · 2024-08-17T04:56:01Z

native/tests/unit-test/src/scheduler_test.cpp

+TEST(schedulerTest, performInCocosThreadOrder) {
+    auto scheduler = std::make_shared<Scheduler>();
+
+    std::vector<int> orderResult;


style: Consider using a thread-safe container for orderResult to prevent potential race conditions

Fix the order of callback by performFunctionInCocosThread and add uni…

6a941e7

…t-test for it. Re: cocos#17012, cocos#17464

dumganhar requested a review from minggo August 15, 2024 09:51

Update license.

80736f9

greptile-apps bot reviewed Aug 15, 2024

View reviewed changes

minggo approved these changes Aug 15, 2024

View reviewed changes

Use std::this_thread::sleep_for

3231bdc

greptile-apps bot reviewed Aug 15, 2024

View reviewed changes

Try fix ci error

dce2e37

greptile-apps bot reviewed Aug 15, 2024

View reviewed changes

Update scheduler_test.cpp

88e0adc

greptile-apps bot reviewed Aug 16, 2024

View reviewed changes

Remove other unit test to figure out

07beedc

[ RUN ] schedulerTest.performInCocosThreadOrder unknown file: error: SEH exception with code 0xc0000005 thrown in the test body. [ FAILED ] schedulerTest.performInCocosThreadOrder (0 ms)

dumganhar marked this pull request as draft August 16, 2024 03:07

greptile-apps bot reviewed Aug 16, 2024

View reviewed changes

dumganhar added 13 commits August 16, 2024 11:26

Update

2739895

Revert "Update"

f45fc8e

This reverts commit 2739895.

Revert "Remove other unit test to figure out"

fcb1a8c

This reverts commit 07beedc.

Revert "Update scheduler_test.cpp"

e6328bc

This reverts commit 88e0adc.

Use macOS to run unittest

2b4c145

Update path

447c7c3

Print cmake version

de8a621

Use cmake 3.24.3

95cb37a

Update

ab2a432

Update

f8b82e4

Update cmake to 3.28.3 for unittest

1413690

Use xcodebuild instead of cmake --build to fix cmake bug: clang: erro…

a554df9

…r: no such file or directory: '$(inherited)'

Update

c9ac9c8

dumganhar marked this pull request as ready for review August 17, 2024 04:40

greptile-apps bot reviewed Aug 17, 2024

View reviewed changes

dumganhar merged commit 243ab7e into cocos:v3.8.4 Aug 17, 2024
24 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix the order of callback by performFunctionInCocosThread and add unit-test for it. #17543

Fix the order of callback by performFunctionInCocosThread and add unit-test for it. #17543

dumganhar commented Aug 15, 2024 •

edited by greptile-apps bot

Loading

greptile-apps bot left a comment

greptile-apps bot left a comment

github-actions bot commented Aug 15, 2024

greptile-apps bot left a comment

greptile-apps bot left a comment

greptile-apps bot left a comment

greptile-apps bot left a comment

greptile-apps bot Aug 16, 2024

greptile-apps bot Aug 16, 2024

greptile-apps bot Aug 16, 2024

greptile-apps bot Aug 16, 2024

greptile-apps bot left a comment

greptile-apps bot Aug 17, 2024

Fix the order of callback by performFunctionInCocosThread and add unit-test for it. #17543

Fix the order of callback by performFunctionInCocosThread and add unit-test for it. #17543

Conversation

dumganhar commented Aug 15, 2024 • edited by greptile-apps bot Loading

Changelog

Continuous Integration

Compatibility Check

Greptile Summary

greptile-apps bot left a comment

Choose a reason for hiding this comment

greptile-apps bot left a comment

Choose a reason for hiding this comment

github-actions bot commented Aug 15, 2024

Interface Check Report

greptile-apps bot left a comment

Choose a reason for hiding this comment

greptile-apps bot left a comment

Choose a reason for hiding this comment

greptile-apps bot left a comment

Choose a reason for hiding this comment

greptile-apps bot left a comment

Choose a reason for hiding this comment

greptile-apps bot Aug 16, 2024

Choose a reason for hiding this comment

greptile-apps bot Aug 16, 2024

Choose a reason for hiding this comment

greptile-apps bot Aug 16, 2024

Choose a reason for hiding this comment

greptile-apps bot Aug 16, 2024

Choose a reason for hiding this comment

greptile-apps bot left a comment

Choose a reason for hiding this comment

greptile-apps bot Aug 17, 2024

Choose a reason for hiding this comment

dumganhar commented Aug 15, 2024 •

edited by greptile-apps bot

Loading