Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

inspector adds prefab and spine previews #17855

Merged
merged 1 commit into from
Nov 18, 2024
Merged

Conversation

knoxHuang
Copy link
Contributor

@knoxHuang knoxHuang commented Nov 14, 2024

Re: # https://github.com/cocos/3d-tasks/issues/6608

Changelog

  • inspector adds prefab and spine previews
image image

Continuous Integration

This pull request:

  • needs automatic test cases check.

    Manual trigger with @cocos-robot run test cases afterward.

  • does not change any runtime related code or build configuration

    If any reviewer thinks the CI checks are needed, please uncheck this option, then close and reopen the issue.


Compatibility Check

This pull request:

  • changes public API, and have ensured backward compatibility with deprecated features.
  • affects platform compatibility, e.g. system version, browser version, platform sdk version, platform toolchain, language version, hardware compatibility etc.
  • affects file structure of the build package or build configuration which requires user project upgrade.
  • introduces breaking changes, please list all changes, affected features and the scope of violation.

Copy link

✅ Package size is not changed

Interface Check Report

This pull request does not change any public interfaces !

@@ -1038,7 +1038,6 @@ export class Skeleton extends UIRenderer {
*/
public updateAnimation (dt: number): void {
this.markForUpdateRenderData();
if (EDITOR_NOT_IN_PREVIEW) return;
Copy link
Contributor

@wuzhiming wuzhiming Nov 14, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

After removing this, spine animations can now play when selected in the editor. This adjustment seemsbetter for developer.

@wuzhiming wuzhiming requested a review from minggo November 14, 2024 06:40
@minggo minggo merged commit 9620a62 into cocos:v3.8.5 Nov 18, 2024
13 checks passed
qiuguohua pushed a commit to qiuguohua/cocos-engine that referenced this pull request Nov 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants