[v3.8.5] Fix Model.setInstancedAttribute doesn't support attribute of INT format. #17858
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
star-e
reviewed
Nov 14, 2024
✅ Package size is not changedInterface Check ReportThis pull request does not change any public interfaces ! |
Fix Model::setInstancedAttribute and SubModule::setInstancedAttribute.
|
@cocos-robot run test cases |
dumganhar
changed the title
dumganhar
changed the title
|
@GengineJS, Please check the result of
Task Details
|
|
@GengineJS, Please check the result of
Task Details
|
dumganhar
approved these changes
Nov 15, 2024
star-e
approved these changes
Nov 15, 2024
qiuguohua
approved these changes
Nov 17, 2024
minggo
approved these changes
Nov 18, 2024
qiuguohua
pushed a commit
to qiuguohua/cocos-engine
that referenced
this pull request
Nov 26, 2024
… INT format. (cocos#17858) * setInstancedAttribute * Add copyTypedArray * Fix Model::setInstancedAttribute and SubModule::setInstancedAttribute. --------- Co-authored-by: James Chen <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.