V3.8.5 oh api12 #17869
Merged
V3.8.5 oh api12 #17869
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Improvement of openharmony's editbox * Remove redundant header file --------- Co-authored-by: qiuguohua <[email protected]> # Conflicts: # templates/openharmony/entry/src/main/cpp/types/libcocos/index.d.ts # templates/openharmony/entry/src/main/ets/components/EditBoxDialog.ets # templates/openharmony/entry/src/main/ets/pages/index.ets # templates/openharmony/entry/src/main/ets/workers/cocos_worker.ts
minggo
reviewed
Nov 18, 2024
minggo
reviewed
Nov 18, 2024
minggo
reviewed
Nov 18, 2024
✅ Package size is not changedInterface Check ReportThis pull request does not change any public interfaces ! |
dumganhar
reviewed
Nov 18, 2024
|
|
||
| _audioPlayerProvider = ccnew AudioPlayerProvider(_engineEngine, _outputMixObject, outputSampleRate, bufferSizeInFrames, fdGetter, &gCallerThreadUtils); | ||
| #elif CC_PLATFORM == CC_PLATFORM_OPENHARMONY | ||
| _audioPlayerProvider = new AudioPlayerProvider(_engineEngine, outputSampleRate, fdGetter, &gCallerThreadUtils); |
There was a problem hiding this comment.
Use ccnew to keep the same coding style.
dumganhar
reviewed
Nov 18, 2024
| _mixController(nullptr), _threadPool(LegacyThreadPool::newCachedThreadPool(1, 8, 5, 2, 2)) | ||
| { | ||
| _mixController = new AudioMixerController(_deviceSampleRate, 2); | ||
| _pcmAudioService = new PcmAudioService(); |
|
@cocos-robot run test cases |
dumganhar
reviewed
Nov 18, 2024
| // This interface needs to be implemented in JSVM, similar to V8. | ||
| // Ref:https://nodejs.org/docs/latest-v17.x/api/n-api.html#object-lifetime-management | ||
| AutoHandleScope(); | ||
| ~AutoHandleScope(); |
There was a problem hiding this comment.
I saw AutoHandleScope is implemented in this PR. Could the comment be removed?
dumganhar
reviewed
Nov 18, 2024
| bundle_name = info.bundleName; | ||
| } | ||
|
|
||
| char* module_info = (char*)malloc((strlen(bundle_name) + strlen(module_name) + 1) * sizeof(char*)); |
There was a problem hiding this comment.
Where is module_info freed?
dumganhar
reviewed
Nov 18, 2024
| char* name = nullptr; | ||
|
|
||
| public: | ||
| static std::unordered_map<std::string, JSFunction> FUNCTION_MAP; |
There was a problem hiding this comment.
For keeping the same coding style, FUNCTION_MAP should be renamed to jsFunctionMap.
Fix some issues with jsvm
|
@qiuguohua, Please check the result of
Task Details
|
|
@qiuguohua, Please check the result of
Task Details
|
|
@cocos-robot run test cases |
minggo
approved these changes
Nov 18, 2024
added 2 commits
November 18, 2024 16:46
|
@qiuguohua I just merge it. The OH compiling error should be fixed later. |
dumganhar
approved these changes
Nov 18, 2024
|
@qiuguohua, Please check the result of
Task Details
|
|
@qiuguohua, Please check the result of
Task Details
|
star-e
approved these changes
Nov 18, 2024
qiuguohua
added a commit
to qiuguohua/cocos-engine
that referenced
this pull request
Nov 26, 2024
* Improvement of openharmony's editbox (cocos#17042) * Improvement of openharmony's editbox * Remove redundant header file --------- Co-authored-by: qiuguohua <[email protected]> # Conflicts: # templates/openharmony/entry/src/main/cpp/types/libcocos/index.d.ts # templates/openharmony/entry/src/main/ets/components/EditBoxDialog.ets # templates/openharmony/entry/src/main/ets/pages/index.ets # templates/openharmony/entry/src/main/ets/workers/cocos_worker.ts * Upgrade the openharmony API to 12 * Remove debugging information * Fix some bugs in the ark engine Fix some issues with jsvm * Release module_info * Fix std::any_of return value not being used --------- Co-authored-by: qiuguohua <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Re: #
Changelog
Continuous Integration
This pull request:
Compatibility Check
This pull request: