fixed #17866: [bug] EventTouch.getUIDelta return wrong delta values on native platforms #17895
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ues on native platforms
minggo
reviewed
Nov 20, 2024
pal/input/native/touch-input.ts
Outdated
| clientY: 0, | ||
| pageX: 0, | ||
| pageY: 0, | ||
| }; |
There was a problem hiding this comment.
Can assign the value with src.
There was a problem hiding this comment.
Updated.
Use Object.assign to copy data from native.
👍 Package size ⤵ -11 bytes, old: 5376156, new: 5376145Interface Check ReportThis pull request does not change any public interfaces ! |
minggo
reviewed
Nov 20, 2024
| } | ||
|
|
||
| private _createEventCacheCallback$ (eventType: InputEventType) { | ||
| return (mouseEvent?: jsb.MouseEvent | jsb.MouseWheelEvent): void => { |
There was a problem hiding this comment.
Why mouseEvent is optional?
There was a problem hiding this comment.
FOR MouseEnter and MouseLeave, they dont have event info and only have type
|
@cocos-robot run test cases |
|
@dumganhar, Please check the result of
Task Details |
|
@dumganhar, Please check the result of
Task Details |
minggo
approved these changes
Nov 21, 2024
dumganhar
added a commit
to dumganhar/cocos-engine
that referenced
this pull request
Nov 22, 2024
…ues on native platforms (cocos#17895)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Re: #17866
Changelog
Continuous Integration
This pull request:
Compatibility Check
This pull request: