Improving the spine preview ui control #17899
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
knoxHuang
commented
Nov 21, 2024
| @@ -654,6 +654,9 @@ export class Skeleton extends UIRenderer { | |||
|
|
|||
| public __preload (): void { | |||
| super.__preload(); | |||
| if (EDITOR_NOT_IN_PREVIEW) { | |||
| this.paused = true; | |||
There was a problem hiding this comment.
The editor should stop playing by default
wuzhiming
reviewed
Nov 21, 2024
| @@ -191,6 +194,7 @@ const Elements = { | |||
| close() { | |||
| const panel = this; | |||
|
|
|||
| callFunction('stop').then(() => {}); | |||
| @@ -259,6 +265,9 @@ const Elements = { | |||
| ready() { | |||
| const panel = this; | |||
|
|
|||
| panel.$.timeScale.addEventListener('change', (event) => { | |||
| callFunction('setTimeScale', Number(event.target.value)).then(() => {}); | |||
✅ Package size is not changedInterface Check ReportThis pull request does not change any public interfaces ! |
wuzhiming
approved these changes
Nov 21, 2024
minggo
approved these changes
Nov 21, 2024
knoxHuang
added a commit
to knoxHuang/engine-2
that referenced
this pull request
Nov 21, 2024
* Improving the spine preview ui control
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Re: #
https://forum.cocos.org/t/topic/163455/36?u=knox
Changelog
Continuous Integration
This pull request:
Compatibility Check
This pull request: