Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[v3.8.6] Continue to remove unused platforms support. #17902

Merged
merged 2 commits into from
Nov 22, 2024

Conversation

dumganhar
Copy link
Contributor

Re: #

Changelog


Continuous Integration

This pull request:

  • needs automatic test cases check.

    Manual trigger with @cocos-robot run test cases afterward.

  • does not change any runtime related code or build configuration

    If any reviewer thinks the CI checks are needed, please uncheck this option, then close and reopen the issue.


Compatibility Check

This pull request:

  • changes public API, and have ensured backward compatibility with deprecated features.
  • affects platform compatibility, e.g. system version, browser version, platform sdk version, platform toolchain, language version, hardware compatibility etc.
  • affects file structure of the build package or build configuration which requires user project upgrade.
  • introduces breaking changes, please list all changes, affected features and the scope of violation.

@dumganhar dumganhar requested a review from minggo November 21, 2024 11:14
@dumganhar
Copy link
Contributor Author

@W-MTZing

@dumganhar
Copy link
Contributor Author

@cocos-robot run test cases

Copy link

github-actions bot commented Nov 21, 2024

👍 Package size ⤵ -207 bytes, old: 5376245, new: 5376038

Interface Check Report

! WARNING this pull request has changed these public interfaces:

@@ -63519,20 +63519,16 @@
             OHOS = "OHOS",
             OPENHARMONY = "OPENHARMONY",
             WECHAT_GAME = "WECHAT_GAME",
             WECHAT_MINI_PROGRAM = "WECHAT_MINI_PROGRAM",
-            BAIDU_MINI_GAME = "BAIDU_MINI_GAME",
             XIAOMI_QUICK_GAME = "XIAOMI_QUICK_GAME",
             ALIPAY_MINI_GAME = "ALIPAY_MINI_GAME",
             TAOBAO_CREATIVE_APP = "TAOBAO_CREATIVE_APP",
             TAOBAO_MINI_GAME = "TAOBAO_MINI_GAME",
             BYTEDANCE_MINI_GAME = "BYTEDANCE_MINI_GAME",
             OPPO_MINI_GAME = "OPPO_MINI_GAME",
             VIVO_MINI_GAME = "VIVO_MINI_GAME",
             HUAWEI_QUICK_GAME = "HUAWEI_QUICK_GAME",
-            COCOSPLAY = "COCOSPLAY",
-            LINKSURE_MINI_GAME = "LINKSURE_MINI_GAME",
-            QTT_MINI_GAME = "QTT_MINI_GAME",
             MIGU_MINI_GAME = "MIGU_MINI_GAME"
         }
         export enum _pal_system_info_enum_type_browser_type__BrowserType {
             /**

Copy link

@dumganhar, Please check the result of run test cases:

Task Details

Platform build boot runned crashScene FailScene
web-mobile PASS PASS FAIL BuildTimeConstantsTest
ios PASS PASS FAIL BuildTimeConstantsTest
mac PASS PASS FAIL BuildTimeConstantsTest

Copy link

@dumganhar, Please check the result of run test cases:

Task Details

Platform build boot runned crashScene FailScene
windows PASS PASS FAIL BuildTimeConstantsTest
android PASS PASS FAIL BuildTimeConstantsTest
wechatgame PASS PASS FAIL BuildTimeConstantsTest

@minggo
Copy link
Contributor

minggo commented Nov 22, 2024

Please send it to v3.8.6

@minggo minggo self-requested a review November 22, 2024 01:31
@dumganhar dumganhar changed the base branch from v3.8.5 to v3.8.6 November 22, 2024 01:46
@dumganhar dumganhar force-pushed the 385-remove-unsed-platforms branch 2 times, most recently from 1a232ea to fec02cb Compare November 22, 2024 01:48
@dumganhar dumganhar changed the title [v3.8.5] Continue to remove unused platforms support. [v3.8.6] Continue to remove unused platforms support. Nov 22, 2024
@dumganhar dumganhar force-pushed the 385-remove-unsed-platforms branch from fec02cb to 6608200 Compare November 22, 2024 01:50
@minggo minggo merged commit 667005f into cocos:v3.8.6 Nov 22, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants