Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the issue where setting targetTexture for the Camera component in gameview has no effect. #17995

Merged
merged 1 commit into from
Dec 2, 2024

Conversation

wuzhiming
Copy link
Contributor

Re: #
https://forum.cocos.org/t/topic/157242/67

Changelog


Continuous Integration

This pull request:

  • needs automatic test cases check.

    Manual trigger with @cocos-robot run test cases afterward.

  • does not change any runtime related code or build configuration

    If any reviewer thinks the CI checks are needed, please uncheck this option, then close and reopen the issue.


Compatibility Check

This pull request:

  • changes public API, and have ensured backward compatibility with deprecated features.
  • affects platform compatibility, e.g. system version, browser version, platform sdk version, platform toolchain, language version, hardware compatibility etc.
  • affects file structure of the build package or build configuration which requires user project upgrade.
  • introduces breaking changes, please list all changes, affected features and the scope of violation.

@wuzhiming wuzhiming requested a review from minggo December 2, 2024 08:22
Copy link

github-actions bot commented Dec 2, 2024

✅ Package size is not changed

Interface Check Report

This pull request does not change any public interfaces !

@minggo
Copy link
Contributor

minggo commented Dec 2, 2024

Did editor change macro or other things?

@wuzhiming
Copy link
Contributor Author

Did editor change macro or other things?

when editor is in preview mode it will set EDITOR_NOT_IN_PREVIEW to false, the EDITOR_NOT_IN_PREVIEW macro is used to distinguish whether the editor is in preview mode.

@minggo
Copy link
Contributor

minggo commented Dec 2, 2024

So this component has the problem for a long time?

@wuzhiming
Copy link
Contributor Author

So this component has the problem for a long time?

It's only occurs in Preview in Editor, is works fine in Preview in Browser.

@minggo minggo merged commit 01e98e8 into cocos:v3.8.6 Dec 2, 2024
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants