-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix the issue on the web where calling spine.setAttachment causes visual glitches due to using incorrect textures. #18002
Conversation
|
native/cocos/editor-support/spine-wasm/AtlasAttachmentLoaderExtension.cpp
Outdated
Show resolved
Hide resolved
native/cocos/editor-support/spine-wasm/AtlasAttachmentLoaderExtension.h
Outdated
Show resolved
Hide resolved
auto* skin = skins[i]; | ||
auto entries = skin->getAttachments(); | ||
while (entries.hasNext()) { | ||
Skin::AttachmentMap::Entry entry = entries.next(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Use reference too.
@@ -5,11 +5,11 @@ | |||
|
|||
class AttachmentVertices { | |||
public: | |||
AttachmentVertices(int verticesCount, uint16_t *triangles, int trianglesCount, uint32_t textureId); | |||
AttachmentVertices(int verticesCount, uint16_t *triangles, int trianglesCount, const spine::String& textureId); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In this PR, you changed the parameter type from uint32_t
to const spine::String &
which indicates the region-page-name
, it's a texture atlas name, right? If so , using the old textureId
name seems not to be suitable.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
After call the function updateAttachmentVerticesTextureId, texture will store texute's uuid
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So I recommend to rename the parameter name to textureUUID
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed
native/cocos/editor-support/spine-wasm/spine-skeleton-instance.h
Outdated
Show resolved
Hide resolved
|
This reverts commit 055004c.
Re: #
https://forum.cocos.org/t/topic/160058/60
https://forum.cocos.org/t/topic/153213
Changelog
Continuous Integration
This pull request:
Compatibility Check
This pull request: