Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

To fix the issue of image stretching after resizing a reflection probe. #18004

Merged
merged 2 commits into from
Dec 5, 2024
Merged

To fix the issue of image stretching after resizing a reflection probe. #18004

merged 2 commits into from
Dec 5, 2024

Conversation

GengineJS
Copy link
Contributor

No description provided.

@GengineJS GengineJS requested a review from star-e December 5, 2024 03:49
@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 5, 2024

⚠️ Package size ⤴ 364 bytes, old: 5440811, new: 5441175

Interface Check Report

! WARNING this pull request has changed these public interfaces:

@@ -5591,9 +5591,8 @@
         protected _sourceCamera: Camera | null;
         protected _probe: renderer.scene.ReflectionProbe | null;
         protected _previewSphere: Node | null;
         protected _previewPlane: Node | null;
-        constructor();
         /**
          * @en
          * Gets or sets the size of the box
          * @zh

@star-e star-e merged commit dd096b0 into cocos:v3.8.6 Dec 5, 2024
12 checks passed
dumganhar
dumganhar reviewed Dec 6, 2024
View reviewed changes
cocos/3d/reflection-probe/reflection-probe-component.ts
@@ -105,10 +105,6 @@ export class ReflectionProbe extends Component {

private _position = new Vec3(0, 0, 0);

constructor () {
super();
}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removing the default constructor will make the package size bigger. So don't remove it.

dumganhar
dumganhar reviewed Dec 6, 2024
View reviewed changes
cocos/3d/reflection-probe/reflection-probe-component.ts
@@ -327,6 +323,12 @@ export class ReflectionProbe extends Component {
}
}

private _handleResize$ (): void {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't add $ now since we will write a babel plugin to mangle the private variables.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dumganhar dumganhar dumganhar left review comments

@star-e star-e star-e approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@GengineJS @dumganhar @star-e